Bug 238828 - Possible build race: lib/libsysdecode/tables.h:948: error: 'IPV6_MIN_MEMBERSHIPS' undeclared
Summary: Possible build race: lib/libsysdecode/tables.h:948: error: 'IPV6_MIN_MEMBERSH...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-26 19:39 UTC by Li-Wen Hsu
Modified: 2024-10-27 13:28 UTC (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Li-Wen Hsu freebsd_committer freebsd_triage 2019-06-26 19:39:33 UTC 
https://ci.freebsd.org/job/FreeBSD-head-sparc64-build/13695/console

--- all_subdir_lib/libsysdecode ---
In file included from /usr/src/lib/libsysdecode/flags.c:90:
/usr/obj/usr/src/sparc64.sparc64/lib/libsysdecode/tables.h:948: error: 'IPV6_MIN_MEMBERSHIPS' undeclared here (not in a function)
Comment 1 ota 2019-06-26 23:33:29 UTC 
Build will succeed after removing the temporary copy - /usr/obj/usr/src/sparc64.sparc64/lib/libsysdecode/tables.h

I also encountered the same error and removed to proceed.
Comment 2 Alan Somers freebsd_committer freebsd_triage 2019-07-13 15:56:50 UTC 
Has there been any progress on this issue?  During buildworld it's merely an annoyance, but it renders "make universe" nearly impossible.
Comment 3 Li-Wen Hsu freebsd_committer freebsd_triage 2019-07-25 07:58:49 UTC 
r350301 (and r350322) is trying to workaround this.
Comment 4 Ed Maste freebsd_committer freebsd_triage 2019-07-25 16:15:36 UTC 
350301 (and followon fixes) should be a partial workaround for this issue but as pointed out in the 350301 commit message we need a way to add a dependency on all of the headers it uses.
Comment 5 Ed Maste freebsd_committer freebsd_triage 2019-07-25 16:17:00 UTC 
My approach in https://reviews.freebsd.org/D21069
Comment 6 Ed Maste freebsd_committer freebsd_triage 2019-08-16 20:20:13 UTC 
https://reviews.freebsd.org/D21295
Comment 7 commit-hook freebsd_committer freebsd_triage 2019-08-16 22:34:20 UTC 
A commit references this bug:

Author: bdrewery
Date: Fri Aug 16 22:34:11 UTC 2019
New revision: 351151
URL: https://svnweb.freebsd.org/changeset/base/351151

Log:
  Rework r339635 to fix .depend.tables.h handling.

  Avoid touching the tables.h file unless it has changed to avoid unneeded
  rebuilds.

  Also revert r350301's explicit dependencies.

  Reviewed by:	emaste
  MFC after:	2 weeks
  X-MFC-With:	r339635 (kevans request)
  PR:		238828
  Sponsored by:	DellEMC
  Differential Revision:	https://reviews.freebsd.org/D21295

Changes:
  head/lib/libsysdecode/Makefile
  head/lib/libsysdecode/mktables
Comment 8 Mark Johnston freebsd_committer freebsd_triage 2024-10-27 13:28:07 UTC 
I believe we haven't seen this particular build failure in a long time.