Bug 238874 - libl.a not generated in /usr/lib32
Summary: libl.a not generated in /usr/lib32
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 12.0-STABLE
Hardware: amd64 Any
: --- Affects Some People
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-28 22:37 UTC by Robert Clausecker
Modified: 2019-07-04 10:49 UTC (History)
2 users (show)

See Also:

Attachments
patch (463 bytes, patch)
2019-06-29 16:00 UTC, Tijl Coosemans 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2019-06-28 22:37:04 UTC 
The library libl.a containing auxiliary code for lexers generated with lex(1) is not generated for i386 even if lib32 support is enabled.  This stops me from compiling projects requiring the libl for i386 on amd64 FreeBSD.

I believe this is not intentional as the similar liby.a for yacc(1) is generated in /usr/lib32.

Please provide an i386 libl.a in /usr/lib32 on amd64.
Comment 1 Tijl Coosemans freebsd_committer freebsd_triage 2019-06-29 16:00:00 UTC 
Created attachment 205414 [details]
patch

This simple patch fixes the problem.  It also applies to stable/12.  A proper fix is probably to move usr.bin/lex/lib to lib/libl, but this requires more extensive changes to Makefile1.inc.
Comment 2 Tijl Coosemans freebsd_committer freebsd_triage 2019-06-29 16:02:46 UTC 
Maybe Warner can give some input here.
Comment 3 Warner Losh freebsd_committer freebsd_triage 2019-06-29 16:05:53 UTC 
I agree with Tijl.

This patch is perfect for commit + quick MFC.

It does suffer exactly what Tijl says: we should have a 'reach over' makefile in lib/libl that builds this and we should adjust things accordingly. This means more directories for tool lists, etc. That's the better, long term solution.

There's no reason for the current state of affairs, other than I suppose it was easier when it was done originally.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-06-29 17:02:07 UTC 
A commit references this bug:

Author: tijl
Date: Sat Jun 29 17:01:56 UTC 2019
New revision: 349548
URL: https://svnweb.freebsd.org/changeset/base/349548

Log:
  Build lib32 libl.  The library is built from usr.bin/lex/lib.  It would be
  better to move this directory to lib/libl, but this requires more extensive
  changes to Makefile.inc1.  This simple fix can be MFCed quickly.

  PR:		238874
  Reviewed by:	imp
  MFC after:	3 days

Changes:
  head/Makefile.libcompat
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-07-04 10:16:50 UTC 
A commit references this bug:

Author: tijl
Date: Thu Jul  4 10:16:45 UTC 2019
New revision: 349721
URL: https://svnweb.freebsd.org/changeset/base/349721

Log:
  MFC r349548:

  Build lib32 libl.  The library is built from usr.bin/lex/lib.  It would be
  better to move this directory to lib/libl, but this requires more extensive
  changes to Makefile.inc1.  This simple fix can be MFCed quickly.

  PR:		238874
  Reviewed by:	imp

Changes:
_U  stable/12/
  stable/12/Makefile.libcompat
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-07-04 10:41:12 UTC 
A commit references this bug:

Author: tijl
Date: Thu Jul  4 10:41:09 UTC 2019
New revision: 349722
URL: https://svnweb.freebsd.org/changeset/base/349722

Log:
  MFC r349548:

  Build lib32 libl.  The library is built from usr.bin/lex/lib.  It would be
  better to move this directory to lib/libl, but this requires more extensive
  changes to Makefile.inc1.  This simple fix can be MFCed quickly.

  PR:		238874
  Reviewed by:	imp

Changes:
_U  stable/11/
  stable/11/Makefile.libcompat