Created attachment 205714 [details]
[patch] workaround for snwprintf undefined reference if STAGING=on

'make -C /usr/ports/emulators/wine-devel WITH=STAGING' fails after the update to 4.12:

 .
 .
gcc8 -m64 -c -o classes.o classes.c -I. -I../../include -I../.. -D__WINESRC__ -D_SHELL32_ -D_REENTRANT -fPIC \
  -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers \
  -Wno-packed-not-aligned -Wshift-overflow=2 -Wstrict-prototypes -Wtype-limits \
  -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith -Wlogical-op -isystem \
  /usr/local/include -O2 -pipe  -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc8 -isystem /usr/local/include -fno-strict-aliasing
/usr/local/bin/ld: dialog.o: in function `SetupPromptForDiskW':
dialog.c:(.text+0x10c0): undefined reference to `snwprintf'
collect2: error: ld returned 1 exit status
winegcc: gcc8 failed
gmake[3]: *** [Makefile:506: setupapi.dll.so] Error 2
gmake[3]: Leaving directory '/d/local/users/jhein/.nobak/wd/usr/ports/emulators/wine-devel/work/wine-4.12/dlls/setupapi'


If you replace snwprintf with _snwprintf in the patched dialog.c (from the staging patchset), the build succeeds:

--- dlls/setupapi/dialog.c.orig 2019-07-12 09:18:10.588254000 +0000
+++ dlls/setupapi/dialog.c      2019-07-12 11:32:31.303208000 +0000
@@ -249,7 +249,7 @@ UINT WINAPI SetupPromptForDiskW(HWND hwn

         if (lstrlenW(PathToSource) + 1 + lstrlenW(FileSought) < sizeof(filepath))
         {
-            snwprintf(filepath, MAX_PATH, format, PathToSource, FileSought);
+            _snwprintf(filepath, MAX_PATH, format, PathToSource, FileSought);

             if (GetFileAttributesW(filepath) != INVALID_FILE_ATTRIBUTES)
             {