Bug 239482 - science/nest: fix build with GCC-based architectures
Summary: science/nest: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Piotr Kubaj
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-27 21:50 UTC by Piotr Kubaj
Modified: 2019-09-21 16:35 UTC (History)
1 user (show)

See Also:
yuri: maintainer-feedback+

Attachments
patch (883 bytes, patch)
2019-07-27 21:50 UTC, Piotr Kubaj 		yuri: maintainer-approval-
Details | Diff
v2 (1022 bytes, patch)
2019-09-20 11:53 UTC, Piotr Kubaj 		yuri: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-07-27 21:50:37 UTC 
Created attachment 206106 [details]
patch

nestkernel/simulation_manager.h needs include sys/time.h for timeval struct when compiling with GCC.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2019-07-27 22:18:15 UTC 
Hi Piotr,

The right way is for the missing "#include <sys/time.h>" to be submitted as PR to their GitHub account. Then this PR patch should be back-ported with:
> PATCH_SITES=	https://github.com/${GH_PROJECT}/${PORTNAME}/commit/
> PATCHFILES=	{commit-hash}.patch:-p1


Yuri
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2019-08-02 10:44:55 UTC 
This builds for me on both amd64 and powerpc64.
Comment 3 Piotr Kubaj freebsd_committer freebsd_triage 2019-08-24 12:54:45 UTC 
https://github.com/nest/nest-simulator/pull/1273
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2019-08-24 18:28:32 UTC 
Piotr,

The correct way of doing this is to submit the pull request for the GitHub project https://github.com/nest/nest-simulator because '#include <sys/time.h>' is just missing there. Only by accident it manifests only on gcc systems.

Please submit a pull request and update the patch using PATCH* statements.

Thanks!
Yuri
Comment 5 Piotr Kubaj freebsd_committer freebsd_triage 2019-08-24 19:08:05 UTC 
(In reply to Yuri Victorovich from comment #4)
Yes, I submitted a pull request.
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2019-08-24 20:00:59 UTC 
(In reply to Piotr Kubaj from comment #5)

Great!
Update the patch then.

Yuri
Comment 7 Piotr Kubaj freebsd_committer freebsd_triage 2019-09-20 11:53:33 UTC 
Created attachment 207648 [details]
v2
Comment 8 commit-hook freebsd_committer freebsd_triage 2019-09-21 16:35:28 UTC 
A commit references this bug:

Author: pkubaj
Date: Sat Sep 21 16:34:48 UTC 2019
New revision: 512523
URL: https://svnweb.freebsd.org/changeset/ports/512523

Log:
  science/nest: fix build with GCC-based architectures

  nestkernel/simulation_manager.h needs include sys/time.h for timeval struct when compiling with GCC.

  PR:		239482
  Approved by:	yuri (maintainer), linimon (mentor)

Changes:
  head/science/nest/Makefile
  head/science/nest/distinfo