Bug 240197 - print/lyx - upgrade to 2.3.3
Summary: print/lyx - upgrade to 2.3.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Raphael Kubo da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-29 19:17 UTC by Mikhail Teterin
Modified: 2019-11-23 16:25 UTC (History)
0 users

See Also:
rakuco: maintainer-feedback+


Attachments
Upgrade lyx to 2.3.3. Exclude 3rdparty pieces (3.03 KB, patch)
2019-08-29 19:17 UTC, Mikhail Teterin
rakuco: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Teterin freebsd_committer freebsd_triage 2019-08-29 19:17:07 UTC
Created attachment 207008 [details]
Upgrade lyx to 2.3.3. Exclude 3rdparty pieces

The new version is available upstream since June. The proposed patch switches to 2.3.3 and prevents irrelevant subdirectories from even being extracted.

This not only saves about 20Mb of diskspace, but helps guard against a miscompilation -- for example, using headers from 3rdparty/mythes/ while linking against ${PREFIX}/lib/libmythes.
Comment 1 Raphael Kubo da Costa freebsd_committer freebsd_triage 2019-09-13 10:27:00 UTC
Comment on attachment 207008 [details]
Upgrade lyx to 2.3.3. Exclude 3rdparty pieces

looks good to me, thank you!
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-11-23 16:25:09 UTC
A commit references this bug:

Author: rakuco
Date: Sat Nov 23 16:25:00 UTC 2019
New revision: 518252
URL: https://svnweb.freebsd.org/changeset/ports/518252

Log:
  Update to 2.3.3.

  Also exclude 3rdparty/ and a few other directories when extracting the
  tarball. This saves some disk space and prevents any bundled
  dependencies from accidentally sneaking in.

  Based on a patch submitted by mi@.

  PR:		240197
  Submitted by:	mi

Changes:
  head/print/lyx/Makefile
  head/print/lyx/distinfo
  head/print/lyx/files/patch-Makefile.am
  head/print/lyx/files/patch-boost-1.69
  head/print/lyx/files/patch-configure.ac
  head/print/lyx/pkg-plist