lib.libarchive.functional_test.test_write_filter_zstd starts failing after r352482 (or r352483): https://ci.freebsd.org/job/FreeBSD-head-amd64-test/12599/testReport/junit/lib.libarchive/functional_test/test_write_filter_zstd/ https://ci.freebsd.org/job/FreeBSD-head-i386-test/6737/testReport/junit/lib.libarchive/functional_test/test_write_filter_zstd/ 485: test_write_filter_zstd /usr/src/contrib/libarchive/libarchive/test/test_write_filter_zstd.c:145: Assertion failed: used2 < used1 Description: compression-level=6 wrote 746 bytes, default wrote 744 bytes
A commit references this bug: Author: lwhsu Date: Thu Sep 19 13:23:25 UTC 2019 New revision: 352515 URL: https://svnweb.freebsd.org/changeset/base/352515 Log: Temporarily add test_write_filter_zstd BROKEN_TESTS as it always fails in CI There is no trivial way to mark single libarchive test skip currently so just add it to BROKEN_TESTS for now. PR: 240683 Sponsored by: The FreeBSD Foundation Changes: head/lib/libarchive/tests/Makefile
What is weird is yes I can reproduce this bug but only under bhyve, not on regular amd64 machines. I am adding mm@ to see if he has more insight
I can't reproduce this either natively or on CHERI RISC-V. Maybe we should try removing it from BROKEN_TESTS?
(In reply to Alex Richardson from comment #3) I haven't checked this for a while, maybe it was fixed silently. Please check it again in bhyve and feel free to enable it. I think we need a "try broken" CI job to monitor if the skipped/disabled tests get fixed.
(In reply to Li-Wen Hsu from comment #4) > I think we need a "try broken" CI job to monitor if the skipped/disabled tests > get fixed. Ideally the failing tests would just be XFAIL and not fail the whole test / generate email, but absent that having a regular job that tries the broken/excluded tests indeed sounds like a good idea.
We could check the test case name in functional_test.sh?
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=218f80226b82763c3cbd48de560959ad546b5e26 commit 218f80226b82763c3cbd48de560959ad546b5e26 Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2024-10-29 15:11:28 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2024-10-29 15:11:28 +0000 libarchive tests: Re-enable a broken test It passes and so appears to have been silently fixed at some point. PR: 240683 MFC after: 1 week lib/libarchive/tests/Makefile | 3 --- 1 file changed, 3 deletions(-)
A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=4c0effbb1ddf85fa8d7b94e8b3767acd11a38b76 commit 4c0effbb1ddf85fa8d7b94e8b3767acd11a38b76 Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2024-10-29 15:11:28 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2024-11-05 00:55:43 +0000 libarchive tests: Re-enable a broken test It passes and so appears to have been silently fixed at some point. PR: 240683 MFC after: 1 week (cherry picked from commit 218f80226b82763c3cbd48de560959ad546b5e26) lib/libarchive/tests/Makefile | 3 --- 1 file changed, 3 deletions(-)