Bug 241327 - mail/roundcube: Broken NSC option
Summary: mail/roundcube: Broken NSC option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alex Dupre
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-18 13:54 UTC by Tobias Kortkamp
Modified: 2019-10-21 08:36 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (ale)

Attachments
roundcube.diff (4.27 KB, patch)
2019-10-18 13:54 UTC, Tobias Kortkamp 		tobik: maintainer-approval? (ale)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2019-10-18 13:54:57 UTC 
Created attachment 208405 [details]
roundcube.diff

The NSC option has been basically broken in ports r423243 where 

.if ${PORT_OPTIONS:MNSC}
post-extract:
	...
.endif

has been replaced with

post-extract-NSC:
	...

which is not equivalent and wrong (note the missing -on suffix).

This was three years ago and the port has been updated multiple
times since then.  Is files/spellchecker.php still functional?
Should we fix the option or remove it (the attached patch remove it)?
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-10-21 08:36:37 UTC 
A commit references this bug:

Author: ale
Date: Mon Oct 21 08:36:11 UTC 2019
New revision: 515090
URL: https://svnweb.freebsd.org/changeset/ports/515090

Log:
  Update to 1.3.10 release and fix NSC option [1].

  PR:		241327 [1]
  Submitted by:	tobik

Changes:
  head/mail/roundcube/Makefile
  head/mail/roundcube/distinfo