Bug 241361 - databases/db5, databases/db6: Hook up DEBUG options helpers
Summary: databases/db5, databases/db6: Hook up DEBUG options helpers
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthias Andree
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-20 09:14 UTC by Tobias Kortkamp
Modified: 2019-10-21 18:23 UTC (History)
1 user (show)

See Also:
mandree: maintainer-feedback+

Attachments
db.diff (896 bytes, patch)
2019-10-20 09:14 UTC, Tobias Kortkamp 		mandree: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2019-10-20 09:14:53 UTC 
Created attachment 208451 [details]
db.diff

It's just dangling there at the moment for no reason that I can see.
Comment 1 Matthias Andree freebsd_committer freebsd_triage 2019-10-20 22:03:56 UTC 
do we expose everything as option? Do we need to add it explicitly? We don't need to list DOCS either, for instance. Will check in more depth another day.
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2019-10-20 22:09:28 UTC 
> We don't need to list DOCS either

Of course we need to.  You are confusing OPTIONS_DEFINE with OPTIONS_DEFAULT.
Comment 3 Matthias Andree freebsd_committer freebsd_triage 2019-10-21 18:18:10 UTC 
I rather thought I'd had it somewhere but don't care enough to dig up the history. I am testing the builds and will commit in a moment.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-10-21 18:21:20 UTC 
A commit references this bug:

Author: mandree
Date: Mon Oct 21 18:21:14 UTC 2019
New revision: 515117
URL: https://svnweb.freebsd.org/changeset/ports/515117

Log:
  databases/db5, databases/db6: Hook up DEBUG options helpers

  PR:		241361
  Submitted by:	tobik@
  MFH:		2019Q4 (blanket, adds an option that defaults to off)

Changes:
  head/databases/db5/Makefile
  head/databases/db6/Makefile
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-10-21 18:23:22 UTC 
A commit references this bug:

Author: mandree
Date: Mon Oct 21 18:23:11 UTC 2019
New revision: 515118
URL: https://svnweb.freebsd.org/changeset/ports/515118

Log:
  MFH: r515117

  databases/db5, databases/db6: Hook up DEBUG options helpers

  PR:		241361
  Submitted by:	tobik@

  Approved by:	ports-secteam (blanket, adds an OPTION that defaults to off)

Changes:
_U  branches/2019Q4/
  branches/2019Q4/databases/db5/Makefile
  branches/2019Q4/databases/db6/Makefile