Created attachment 208906 [details] Proposed patch The new SSHguard script performs an incomplete check of pidfile, which is not needed on FreeBSD and can prevent the service from starting. The issue seems to be introduced by https://bitbucket.org/sshguard/sshguard/commits/32a4676599a900a7a072f66303d9c48b22d1107c Reproduction case: 1. echo "blah" > /var/run/sshguard.pid 2. service sshguard start Expected result: sshguard should start and write the PID. Actual result: sshguard won't start; if the command was executed manually, the user would see "/var/run/sshguard.pid already exists; is SSHGuard already running?". Proposed patch attached.
Comment on attachment 208906 [details] Proposed patch This patch is: Approved by: portmgr (blanket(s): ports compliance, bugfix) Pending / contingent on QA
If quarterly is affected, please MFH
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/94102580
A commit references this bug: Author: delphij Date: Sun Nov 10 18:34:55 UTC 2019 New revision: 517220 URL: https://svnweb.freebsd.org/changeset/ports/517220 Log: Remove redundant pidfile check. This fixes an issue that SSHguard won't start after an incompelete shutdown. PR: ports/241751 Approved by: portmgr (bugfix blanket) MFH: 2019Q4 Changes: head/security/sshguard/Makefile head/security/sshguard/files/patch-src_sshguard.in
A commit references this bug: Author: delphij Date: Sun Nov 10 18:35:56 UTC 2019 New revision: 517221 URL: https://svnweb.freebsd.org/changeset/ports/517221 Log: MFH: r517220 Remove redundant pidfile check. This fixes an issue that SSHguard won't start after an incompelete shutdown. PR: ports/241751 Approved by: portmgr (bugfix blanket) Approved by: ports-secteam (bugfix blanket) Changes: _U branches/2019Q4/ branches/2019Q4/security/sshguard/Makefile branches/2019Q4/security/sshguard/files/patch-src_sshguard.in