Bug 241982 - net/multicat: Update to 2.3, Take MAINTAINER'ship
Summary: net/multicat: Update to 2.3, Take MAINTAINER'ship
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthias Andree
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2019-11-15 12:18 UTC by Michael Muenz
Modified: 2020-05-05 04:38 UTC (History)
3 users (show)

See Also:
mandree: maintainer-feedback+

Attachments
multicat 2.3 (6.14 KB, patch)
2019-11-15 12:18 UTC, Michael Muenz 		no flags Details | Diff
multicat 2-3, take maintainership (12.77 KB, patch)
2020-05-02 05:11 UTC, Michael Muenz 		no flags Details | Diff
patch 2.3 (12.80 KB, patch)
2020-05-02 19:06 UTC, Michael Muenz 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Muenz 2019-11-15 12:18:56 UTC 
Created attachment 209163 [details]
multicat 2.3

I took an orphaned port where an update is available.

As 2.3 is one year ago I'm not sure if it's neccessary to also took over maintainership. 

I'll let the decision to you. :)
Comment 1 Automation User 2019-11-15 12:34:31 UTC 
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/96203851
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2020-04-30 21:24:11 UTC 
Hi Michael,

Can you update patch with you as maintainer?
Is this run-tested and if so, os version and arch?

Best regards,
Daniel
Comment 3 Michael Muenz 2020-05-02 05:11:33 UTC 
Created attachment 214015 [details]
multicat 2-3, take maintainership
Comment 4 Michael Muenz 2020-05-02 05:13:35 UTC 
Hi Daniel,

I updated the patch.

- patched successfully against 2.2
- portlint -A is happy
- poudriere build in 12.1Ramd64 and 12.1Ri386 is good
- installed pkg via portbuild and able to record streams on a virtual 12.1Ramd64
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2020-05-02 17:17:40 UTC 
Thanks for the update,

Your patch refers to multicat23 as directory and not multicat, can you please fix that?

Thanks for running poudriere etc!
Comment 6 Michael Muenz 2020-05-02 19:06:13 UTC 
Created attachment 214034 [details]
patch 2.3
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2020-05-04 21:07:51 UTC 
Hi,

I think you included a patch by accident?
Comment 8 commit-hook freebsd_committer freebsd_triage 2020-05-04 23:03:57 UTC 
A commit references this bug:

Author: mandree
Date: Mon May  4 23:03:43 UTC 2020
New revision: 533994
URL: https://svnweb.freebsd.org/changeset/ports/533994

Log:
  net/multicat: Update to 2.3, new maintainer

  - pkg-descr: WWW: changed to https://
  - Makefile ordering: PORTDOCS and PKG_PLIST swapped (portclippy suggestion)
  - extra patch of the file "patch" successfully ignored :-)
  - set MAINTAINER (was unmaintained)

  PR:		241982
  Submitted by:	Michael Muenz <m.muenz@gmail.com> (new maintainer)

Changes:
  head/net/multicat/Makefile
  head/net/multicat/distinfo
  head/net/multicat/files/patch-Makefile
  head/net/multicat/files/patch-multicat.c
  head/net/multicat/files/patch-util.c
  head/net/multicat/files/patch-util.h
  head/net/multicat/pkg-descr
Comment 9 Michael Muenz 2020-05-05 04:38:32 UTC 
Patching patch with patch may be like google Goole :)
Sorry, missed it when testing.