1) The current man page lists a "-w size" flag to set the window size ex [-FRrSsv] [-c cmd] [-t tag] [-w size] [file ...] vi [-eFRrS] [-c cmd] [-t tag] [-w size] [file ...] view [-eFrS] [-c cmd] [-t tag] [-w size] [file ...] However attempting to invoke ex/vi/view with "-w $SIZE" gives an error message: $ vi -w 10 a.txt b.txt set: no 23 option: 'set all' gives all option values (same with invoking as ex or view) As best I can tell, either the "-w" option doesn't work, has side-effects, or is improperly documented. I suspect that the solution is to just remove the references to the "-w size" option. 2) Under the ASYNCHRONOUS EVENTS section's SIGWINCH, the reader is referred to the "vi/ex reference manual section Sizing the Screen" but AFAICT, either there is no vi/ex reference manual (if it's referring to an external document) or if that document is the self-same man-page, there is no "Sizing the Screen" section. I'm not sure whether the proper resolution is to add a Sizing the Screen section to the current man-page, or to remove that cross-reference. Or, if it is an external document, providing details on the file-path to the "reference manual".
review D26158
(In reply to Tim Chase from comment #0) Hi Tim, The external document the manual page is referring to is this one: https://docs.freebsd.org/44doc/usd/13.viref/paper.pdf Cheers!
(In reply to Fernando Apesteguía from comment #2) Thanks for both fixing the `-w` and for the link to the article referenced in the man-page. Would it make sense to include this URL in the man-page as well? Especially since this PDF is hosted on the FreeBSD site. (PS: and there was some weird rendering issue viewing that PDF in Chromium, though it appears to render fine in Firefox & `xpdf`, but that's a separate issue)
(In reply to Tim Chase from comment #3) Absolutely, review D26163
man committed in base r366148. Change sent upstream: https://github.com/lichray/nvi2/pull/85
Both changes have been merged upstream: https://github.com/lichray/nvi2/pull/85 https://github.com/lichray/nvi2/pull/86
A commit references this bug: Author: bapt Date: Thu Oct 1 04:26:00 UTC 2020 New revision: 366307 URL: https://svnweb.freebsd.org/changeset/base/366307 Log: Import nvi 2.2.0-05ed8b9 This snapshot just brings a bunch of fixes in particular a fix for vi -w PR: 241985 Reported by: fernape Changes: vendor/nvi/dist/CMakeLists.txt vendor/nvi/dist/catalog/dump.c vendor/nvi/dist/cl/cl.h vendor/nvi/dist/cl/cl_read.c vendor/nvi/dist/cl/cl_term.c vendor/nvi/dist/common/common.h vendor/nvi/dist/common/cut.h vendor/nvi/dist/common/exf.c vendor/nvi/dist/common/key.c vendor/nvi/dist/common/log.c vendor/nvi/dist/common/main.c vendor/nvi/dist/common/mark.c vendor/nvi/dist/common/mem.h vendor/nvi/dist/common/msg.c vendor/nvi/dist/common/options.c vendor/nvi/dist/common/put.c vendor/nvi/dist/common/recover.c vendor/nvi/dist/common/util.c vendor/nvi/dist/ex/ex.c vendor/nvi/dist/ex/ex.h vendor/nvi/dist/ex/ex_argv.c vendor/nvi/dist/ex/ex_bang.c vendor/nvi/dist/ex/ex_cscope.c vendor/nvi/dist/ex/ex_filter.c vendor/nvi/dist/ex/ex_global.c vendor/nvi/dist/ex/ex_script.c vendor/nvi/dist/ex/ex_shell.c vendor/nvi/dist/ex/ex_subst.c vendor/nvi/dist/files/config.h.in vendor/nvi/dist/files/pathnames.h.in vendor/nvi/dist/man/vi.1 vendor/nvi/dist/regex/engine.c vendor/nvi/dist/regex/regexec.c vendor/nvi/dist/vi/v_itxt.c vendor/nvi/dist/vi/v_paragraph.c vendor/nvi/dist/vi/v_section.c vendor/nvi/dist/vi/v_sentence.c vendor/nvi/dist/vi/v_txt.c vendor/nvi/dist/vi/vi.c vendor/nvi/dist/vi/vs_line.c vendor/nvi/dist/vi/vs_msg.c vendor/nvi/dist/vi/vs_refresh.c vendor/nvi/dist/vi/vs_relative.c vendor/nvi/dist/vi/vs_smap.c
A commit references this bug: Author: bapt Date: Thu Oct 1 04:46:29 UTC 2020 New revision: 366309 URL: https://svnweb.freebsd.org/changeset/base/366309 Log: Update nvi to 2.2.0-05ed8b9 This version incorporates many fixes in particular a fix for vi -w Another approach was proposed to merge those fixes (see review), I find it easier to track changes if we keep importing snapshot on regular basis PR: 241985 Reported by: fernape Differential Revision: https://reviews.freebsd.org/D26158 Changes: _U head/contrib/nvi/ head/contrib/nvi/CMakeLists.txt head/contrib/nvi/catalog/dump.c head/contrib/nvi/cl/cl.h head/contrib/nvi/cl/cl_read.c head/contrib/nvi/cl/cl_term.c head/contrib/nvi/common/common.h head/contrib/nvi/common/cut.h head/contrib/nvi/common/exf.c head/contrib/nvi/common/key.c head/contrib/nvi/common/log.c head/contrib/nvi/common/main.c head/contrib/nvi/common/mark.c head/contrib/nvi/common/mem.h head/contrib/nvi/common/msg.c head/contrib/nvi/common/options.c head/contrib/nvi/common/put.c head/contrib/nvi/common/recover.c head/contrib/nvi/common/util.c head/contrib/nvi/ex/ex.c head/contrib/nvi/ex/ex.h head/contrib/nvi/ex/ex_argv.c head/contrib/nvi/ex/ex_bang.c head/contrib/nvi/ex/ex_cscope.c head/contrib/nvi/ex/ex_filter.c head/contrib/nvi/ex/ex_global.c head/contrib/nvi/ex/ex_script.c head/contrib/nvi/ex/ex_shell.c head/contrib/nvi/ex/ex_subst.c head/contrib/nvi/files/config.h.in head/contrib/nvi/files/pathnames.h.in head/contrib/nvi/regex/engine.c head/contrib/nvi/regex/regexec.c head/contrib/nvi/vi/v_itxt.c head/contrib/nvi/vi/v_paragraph.c head/contrib/nvi/vi/v_section.c head/contrib/nvi/vi/v_sentence.c head/contrib/nvi/vi/v_txt.c head/contrib/nvi/vi/vi.c head/contrib/nvi/vi/vs_line.c head/contrib/nvi/vi/vs_msg.c head/contrib/nvi/vi/vs_refresh.c head/contrib/nvi/vi/vs_relative.c head/contrib/nvi/vi/vs_smap.c head/usr.bin/vi/catalog/Makefile head/usr.bin/vi/pathnames.h
^Triage: Assign to committer resolving
A commit in branch stable/12 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=4365415046a352c2b93553502ed3a3758da93197 commit 4365415046a352c2b93553502ed3a3758da93197 Author: Baptiste Daroussin <bapt@FreeBSD.org> AuthorDate: 2020-10-01 04:46:23 +0000 Commit: Baptiste Daroussin <bapt@FreeBSD.org> CommitDate: 2021-09-22 10:28:14 +0000 Update nvi to 2.2.0-05ed8b9 This version incorporates many fixes in particular a fix for vi -w Another approach was proposed to merge those fixes (see review), I find it easier to track changes if we keep importing snapshot on regular basis PR: 241985 Reported by: fernape Differential Revision: https://reviews.freebsd.org/D26158 (cherry picked from commit 755cc40c21ca63388c6a67ba848a908b429e9391) contrib/nvi/CMakeLists.txt | 24 ++++++++++++++-- contrib/nvi/catalog/dump.c | 12 ++++---- contrib/nvi/cl/cl.h | 4 ++- contrib/nvi/cl/cl_read.c | 1 + contrib/nvi/cl/cl_term.c | 6 ++-- contrib/nvi/common/common.h | 10 ++++++- contrib/nvi/common/cut.h | 4 +-- contrib/nvi/common/exf.c | 17 +++++++----- contrib/nvi/common/key.c | 4 +-- contrib/nvi/common/log.c | 4 +-- contrib/nvi/common/main.c | 11 ++++---- contrib/nvi/common/mark.c | 3 +- contrib/nvi/common/mem.h | 60 ++++++++++++++++++++-------------------- contrib/nvi/common/msg.c | 4 +++ contrib/nvi/common/options.c | 20 ++++++++++---- contrib/nvi/common/put.c | 3 +- contrib/nvi/common/recover.c | 9 +++--- contrib/nvi/common/util.c | 10 +++++-- contrib/nvi/ex/ex.c | 9 ++++-- contrib/nvi/ex/ex.h | 8 +++--- contrib/nvi/ex/ex_argv.c | 8 ++++++ contrib/nvi/ex/ex_bang.c | 3 +- contrib/nvi/ex/ex_cscope.c | 10 ++++--- contrib/nvi/ex/ex_filter.c | 3 +- contrib/nvi/ex/ex_global.c | 3 +- contrib/nvi/ex/ex_script.c | 2 ++ contrib/nvi/ex/ex_shell.c | 3 +- contrib/nvi/ex/ex_subst.c | 27 +++++++++--------- contrib/nvi/files/config.h.in | 9 ++++++ contrib/nvi/files/pathnames.h.in | 5 ++-- contrib/nvi/regex/engine.c | 2 +- contrib/nvi/regex/regexec.c | 6 ++-- contrib/nvi/vi/v_itxt.c | 4 +-- contrib/nvi/vi/v_paragraph.c | 10 ++++--- contrib/nvi/vi/v_section.c | 3 +- contrib/nvi/vi/v_sentence.c | 3 +- contrib/nvi/vi/v_txt.c | 11 ++++---- contrib/nvi/vi/vi.c | 4 +-- contrib/nvi/vi/vs_line.c | 10 ++++--- contrib/nvi/vi/vs_msg.c | 13 +++++---- contrib/nvi/vi/vs_refresh.c | 9 ++++-- contrib/nvi/vi/vs_relative.c | 7 +++-- contrib/nvi/vi/vs_smap.c | 4 +-- usr.bin/vi/catalog/Makefile | 3 +- usr.bin/vi/pathnames.h | 5 ++-- 45 files changed, 243 insertions(+), 147 deletions(-)