Created attachment 210298 [details] git(1) diff against base Attached patch against base removes our dependency on gcclibs' libssp/libssp_nonshared and just builds it from our own libc implementation with some stubs for the parts that we don't support.
I don't understand, there are 3 different exp-run requests from 3 different people about libssp..
@Kyle If your patch is different from that in #bug 229348, please attach it there *** This bug has been marked as a duplicate of bug 229348 ***
Re-open, this patch is not duplicate of bug #229348
(In reply to Antoine Brodin from comment #1) The other two are trying to assess when/if it still needs to be linked into libssp, this one is attempting to determine if ours is an all-around suitable replacement. I suspect emaste's supercedes pfg's, then this one's independent because we're both keeping libssp and libssp.so needs to be exercised, and we're swapping out the version linked into libc which could break i386. While their effort could make part of this futile, we're still flexing additional bits that may break.
There is 1 new failure on i386 Failure log: http://pb2.nyi.freebsd.org/data/headi386PR242950-default/2020-01-02_11h04m33s/logs/errors/oo2c-2.1.11_13.log
(In reply to Antoine Brodin from comment #5) Thanks! Looks like libssp_nonshared was missing an -fPIC in the build. I re-tested that the build is fine locally following that change- since it appears to be a leaf port and the only one, I'm going to go ahead and close this and commit. Thanks again for the exp-run!
A commit references this bug: Author: kevans Date: Sat Jan 4 20:19:28 UTC 2020 New revision: 356356 URL: https://svnweb.freebsd.org/changeset/base/356356 Log: Provide libssp based on libc For libssp.so, rebuild stack_protector.c with FORTIFY_SOURCE stubs that just abort built into it. For libssp_nonshared.a, steal stack_protector_compat.c from ^/lib/libc/secure and massage it to maintain that __stack_chk_fail_local is a hidden symbol. libssp is now built unconditionally regardless of {WITH,WITHOUT}_SSP in the build environment, and the gcclibs version has been disconnected from the build in favor of this one. PR: 242950 (exp-run) Reviewed by: kib, emaste, pfg, Oliver Pinter (earlier version) Also discussed with: kan MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D22943 Changes: head/Makefile.inc1 head/ObsoleteFiles.inc head/gnu/lib/Makefile head/lib/Makefile head/lib/libssp/ head/lib/libssp/Makefile head/lib/libssp/Symbol.map head/lib/libssp/Versions.def head/lib/libssp/fortify_stubs.c head/lib/libssp_nonshared/ head/lib/libssp_nonshared/Makefile head/lib/libssp_nonshared/libssp_nonshared.c head/share/mk/local.dirdeps.mk head/share/mk/local.gendirdeps.mk head/share/mk/src.libnames.mk head/tools/build/mk/OptionalObsoleteFiles.inc
(In reply to Antoine Brodin from comment #1) My PR 242941 is trying to eliminate one of the SSP-related components that I believe is not used on most FreeBSD targets.
A commit references this bug: Author: dim Date: Fri Feb 14 19:31:24 UTC 2020 New revision: 357929 URL: https://svnweb.freebsd.org/changeset/base/357929 Log: Remove /usr/include/ssp from BSD.include.dist after r356356 This avoids having to delete it every time with "make delete-old". PR: 242950 MFC after: 2 weeks X-MFC-With: r356356 Changes: head/etc/mtree/BSD.include.dist
A commit references this bug: Author: dim Date: Mon Mar 2 07:13:00 UTC 2020 New revision: 358528 URL: https://svnweb.freebsd.org/changeset/base/358528 Log: MFC r357929: Remove /usr/include/ssp from BSD.include.dist after r356356 This avoids having to delete it every time with "make delete-old". PR: 242950 Changes: _U stable/12/ stable/12/etc/mtree/BSD.include.dist
A commit references this bug: Author: dim Date: Thu May 14 19:41:45 UTC 2020 New revision: 361051 URL: https://svnweb.freebsd.org/changeset/base/361051 Log: MFC r357929: Remove /usr/include/ssp from BSD.include.dist after r356356 This avoids having to delete it every time with "make delete-old". PR: 242950 Changes: _U stable/11/ stable/11/etc/mtree/BSD.include.dist
A commit references this bug: Author: dim Date: Thu May 14 19:56:16 UTC 2020 New revision: 361052 URL: https://svnweb.freebsd.org/changeset/base/361052 Log: MF11 r361051: MFC r357929: Remove /usr/include/ssp from BSD.include.dist after r356356 This avoids having to delete it every time with "make delete-old". Approved by: re (gjb) PR: 242950 Changes: _U releng/11.4/ releng/11.4/etc/mtree/BSD.include.dist