Created attachment 210416 [details] Pass result to key_sendup_mbuf instead of m The method key_spdacquire pass the parameter "m" to key_sendup_mbuf, or this parameter is always NULL (due to the for loop above). It should pass the mbuf "result instead"
I think the patch is correct. However this part of code is unused, this is why it has never triggered the assertion. SPDACQUIRE message was not implemented and it is not hooked to the key_typesw.
(In reply to Masse Nicolas from comment #0) How did you notice the problem?
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=378a2b155aaf853933df5b53e174b3880826488c commit 378a2b155aaf853933df5b53e174b3880826488c Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2025-01-06 23:20:08 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2025-01-06 23:20:18 +0000 netipsec: Pass the right mbuf up Note that key_spdacquire() is dead code, as the SADB_X_SPDACQUIRE message handler is not set. PR: 243057 MFC after: 2 weeks sys/netipsec/key.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=65da23709d2047c996fb9434e68c2ce90ecdc1bb commit 65da23709d2047c996fb9434e68c2ce90ecdc1bb Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2025-01-06 23:20:08 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2025-01-20 00:26:35 +0000 netipsec: Pass the right mbuf up Note that key_spdacquire() is dead code, as the SADB_X_SPDACQUIRE message handler is not set. PR: 243057 MFC after: 2 weeks (cherry picked from commit 378a2b155aaf853933df5b53e174b3880826488c) sys/netipsec/key.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)