Bug 243185 - Remove the legacy way of passing Python version, before flavors were a thing.
Summary: Remove the legacy way of passing Python version, before flavors were a thing.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL: https://reviews.freebsd.org/D23084
Keywords:
Depends on:
Blocks: 242614
  Show dependency tree / graph
 
Reported: 2020-01-08 12:26 UTC by Mathieu Arnold
Modified: 2020-03-16 06:19 UTC (History)
1 user (show)

See Also:
antoine: exp-run+

Attachments
v1 (1.20 KB, patch)
2020-01-08 12:26 UTC, Mathieu Arnold 		no flags Details | Diff
v2 (6.04 KB, patch)
2020-01-08 13:07 UTC, Mathieu Arnold 		no flags Details | Diff
v3 (10.58 KB, patch)
2020-01-08 14:24 UTC, Mathieu Arnold 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Arnold freebsd_committer freebsd_triage 2020-01-08 12:26:04 UTC 
Created attachment 210527 [details]
v1
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2020-01-08 12:27:15 UTC 
This can be committed without an exp-run.
Comment 2 Mathieu Arnold freebsd_committer freebsd_triage 2020-01-08 12:45:25 UTC 
Yeah, I thought that the exp-run would not add anything just after I opened the bug report.

The thing is, I am wondering how to figure out what will break without this.
Comment 3 Mathieu Arnold freebsd_committer freebsd_triage 2020-01-08 13:07:19 UTC 
Created attachment 210532 [details]
v2

After a bit more thoughts, simplify all the code now that PYTHON_VERSION is not a thing we can inherit.
Comment 4 Mathieu Arnold freebsd_committer freebsd_triage 2020-01-08 14:24:14 UTC 
Created attachment 210535 [details]
v3

Bit more stuff.
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-01-09 13:33:48 UTC 
A commit references this bug:

Author: mat
Date: Thu Jan  9 13:32:55 UTC 2020
New revision: 522485
URL: https://svnweb.freebsd.org/changeset/ports/522485

Log:
  Remove the legacy way of passing Python version.

  This was used before flavors were a thing to make sure if you built port
  A with some python version, and it needed port B, port B would also be
  built with the same python version.

  PR:		243185
  Reviewed by:	antoine
  Differential Revision:	https://reviews.freebsd.org/D23084

Changes:
  head/Mk/Uses/python.mk
Comment 6 commit-hook freebsd_committer freebsd_triage 2020-01-09 13:33:51 UTC 
A commit references this bug:

Author: mat
Date: Thu Jan  9 13:33:01 UTC 2020
New revision: 522487
URL: https://svnweb.freebsd.org/changeset/ports/522487

Log:
  Cleanup after removing PYTHON_VERSION from DEPENDS_ARGS.

  Much of the Python version selection code had compat shims around to
  accomodate the transition from before to with flavors. These can now be
  removed.

  PR:		243185
  Reviewed by:	antoine
  Differential Revision:	https://reviews.freebsd.org/D23084

Changes:
  head/Mk/Uses/python.mk