Bug 243284 - ipfw(8) skip-action not a keyword
Summary: ipfw(8) skip-action not a keyword
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Manual Pages (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Ceri Davies
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-12 05:36 UTC by pprocacci
Modified: 2024-01-20 19:04 UTC (History)
4 users (show)

See Also:

Attachments
Fix to manpage ipfw.8 (463 bytes, patch)
2022-09-07 14:24 UTC, Chad Jacob Milios 		milios: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description pprocacci 2020-01-12 05:36:43 UTC 
ipfw add allow record-state skip-action


This text in ipfw(8) uses "skip-action" however, this isn't an available keyword in ipfw.  Please update to use the proper keyword.

Also, if someone could add something to show how to properly configure a stateful NAT, that would go a long way.

Thanks
Comment 1 Chad Jacob Milios 2022-09-07 14:24:16 UTC 
Created attachment 236419 [details]
Fix to manpage ipfw.8

The action was renamed to "defer-action" during review of D1776 but this line in the manual got overlooked.
Comment 2 Mikko Lehto 2023-01-24 22:18:48 UTC 
Here is typical newbie error when blindly following manual page example:

# ipfw add allow record-state skip-action
ipfw: unrecognised option [-1] skip-action

Patch in attachment 236419 [details] works for me™, thank you.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-01-25 18:18:38 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=da52fc464a4c80fdbed551824064d203831b4e7b

commit da52fc464a4c80fdbed551824064d203831b4e7b
Author:     Ceri Davies <ceri@FreeBSD.org>
AuthorDate: 2023-01-25 18:15:18 +0000
Commit:     Ceri Davies <ceri@FreeBSD.org>
CommitDate: 2023-01-25 18:15:18 +0000

    ipfw.8: there never was a "skip-action" action

    It was renamed during review of D1776 but this entry slipped through.

    PR:             243284
    Reported by:    pprocacci@gmail.com
    Obtained from:  Chad Jacob Milios <milios@ccsys.com>

 sbin/ipfw/ipfw.8 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 4 Ceri Davies freebsd_committer freebsd_triage 2023-01-25 18:18:55 UTC 
Corrected, thanks for the report.