Bug 243862 - [patch] whois(1) does not recurse to servers that include a port number
Summary: [patch] whois(1) does not recurse to servers that include a port number
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Mark Johnston
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2020-02-04 07:15 UTC by ben
Modified: 2020-07-26 18:13 UTC (History)
3 users (show)

See Also:

Attachments
fix patch (821 bytes, patch)
2020-02-04 07:15 UTC, ben 		no flags Details | Diff
better patch (3.73 KB, patch)
2020-02-04 22:00 UTC, ben 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ben 2020-02-04 07:15:18 UTC 
Created attachment 211337 [details]
fix patch

ARIN and possibly other whois servers sometimes append a port number to the hostname in a referral, which whois(1) does not recognize.

This can be seen with one of freebsd.org's addresses, which includes a referral to NYI's whois servers on an alternate port:

% whois 96.47.72.84
Comment 1 ben 2020-02-04 22:00:43 UTC 
Created attachment 211359 [details]
better patch
Comment 2 Mark Johnston freebsd_committer freebsd_triage 2020-06-05 20:19:32 UTC 
I posted a lightly modified version of the patch for review here: https://reviews.freebsd.org/D25156
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-07-09 17:27:26 UTC 
A commit references this bug:

Author: markj
Date: Thu Jul  9 17:27:14 UTC 2020
New revision: 363052
URL: https://svnweb.freebsd.org/changeset/base/363052

Log:
  whois: Handle referrals to rwhois servers.

  PR:		243862
  Submitted by:	ben@desync.com
  Differential Revision:	https://reviews.freebsd.org/D25156

Changes:
  head/usr.bin/whois/whois.c
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2020-07-25 23:59:46 UTC 
To committer: does this need an MFC?  Or can this PR just be closed instead.
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-07-26 18:12:59 UTC 
A commit references this bug:

Author: markj
Date: Sun Jul 26 18:12:54 UTC 2020
New revision: 363570
URL: https://svnweb.freebsd.org/changeset/base/363570

Log:
  MFC r363052:
  whois: Handle referrals to rwhois servers.

  PR:	243862

Changes:
_U  stable/12/
  stable/12/usr.bin/whois/whois.c
Comment 6 Mark Johnston freebsd_committer freebsd_triage 2020-07-26 18:13:17 UTC 
(In reply to Mark Linimon from comment #4)
I just missed adding an MFC tag.  Thanks for the reminder.