Bug 243905 - misc/sword: clean Makefile and take maintainership
Summary: misc/sword: clean Makefile and take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-02-05 15:19 UTC by Lorenzo Salvadore
Modified: 2020-02-06 15:54 UTC (History)
1 user (show)

See Also:

Attachments
sword adoption (1.73 KB, patch)
2020-02-05 15:19 UTC, Lorenzo Salvadore 		salvadore: maintainer-approval+
Details | Diff
sword adoption 2 (1.87 KB, patch)
2020-02-05 18:20 UTC, Lorenzo Salvadore 		salvadore: maintainer-approval+
Details | Diff
sword fix WWW (409 bytes, patch)
2020-02-06 09:29 UTC, Lorenzo Salvadore 		salvadore: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lorenzo Salvadore freebsd_committer freebsd_triage 2020-02-05 15:19:31 UTC 
Created attachment 211379 [details]
sword adoption

Patch tested successfully with poudriere on {11.3,12.1}-RELEASE and {i386,amd64}.
Comment 1 Automation User 2020-02-05 15:40:28 UTC 
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/115251656
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2020-02-05 16:41:29 UTC 
Are you sure that the "USE_CXXSTD=    gnu++11" has to go?
Comment 3 Mateusz Piotrowski freebsd_committer freebsd_triage 2020-02-05 16:42:22 UTC 
Also, could you lint the file with portfmt and portclippy?
Comment 4 Lorenzo Salvadore freebsd_committer freebsd_triage 2020-02-05 18:20:45 UTC 
Created attachment 211385 [details]
sword adoption 2

Fixed with the suggested tools (I did not know about them, I knew only about portlint: they are great! I think I have never read about them in the porter handbook) and tested successfully with poudriere on {11.3,12.1}-RELEASE {i386,amd64}.

I confirm that I believe USE_STDCXX can safely be removed: I grepped /usr/ports/Mk for such a variable name but I could not find it. I guess it was replaced long time ago by USES= compiler. Anyway, if the variable is not recognized, it cannot have any effect and it is safe to remove it.
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-02-06 09:20:09 UTC 
A commit references this bug:

Author: 0mp
Date: Thu Feb  6 09:19:48 UTC 2020
New revision: 525370
URL: https://svnweb.freebsd.org/changeset/ports/525370

Log:
  misc/sword: Clean Makefile and assign to new maintainer

  Apart from style changes, also remove broken link from MASTER_SITES.

  PR:		243905
  Submitted by:	salvadore@

Changes:
  head/misc/sword/Makefile
Comment 6 Mateusz Piotrowski freebsd_committer freebsd_triage 2020-02-06 09:21:05 UTC 
Done! Thanks a lot!

BTW, the website link in pkg-descr is broken. You may want to want to try to find a new link (if it exists).

Cheers!
Comment 7 Lorenzo Salvadore freebsd_committer freebsd_triage 2020-02-06 09:29:14 UTC 
Created attachment 211407 [details]
sword fix WWW

Thanks!

I found the right website and updated it in the new attachment. Thanks for noticing the broken link.
Comment 8 Mateusz Piotrowski freebsd_committer freebsd_triage 2020-02-06 15:54:11 UTC 
(In reply to Lorenzo Salvadore from comment #7)
Nice! Thanks a lot!
Comment 9 commit-hook freebsd_committer freebsd_triage 2020-02-06 15:54:38 UTC 
A commit references this bug:

Author: 0mp
Date: Thu Feb  6 15:53:55 UTC 2020
New revision: 525383
URL: https://svnweb.freebsd.org/changeset/ports/525383

Log:
  Update WWW

  PR:		243905
  Submitted by:	salvadore@

Changes:
  head/misc/sword/pkg-descr