Bug 243929 - fstyp: Sync HAMMER1/2 detection support with DragonFly BSD
Summary: fstyp: Sync HAMMER1/2 detection support with DragonFly BSD
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Pedro F. Giffuni
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-06 15:58 UTC by kusumi.tomohiro
Modified: 2020-02-06 23:29 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description kusumi.tomohiro 2020-02-06 15:58:32 UTC 
The FreeBSD fstyp supports HAMMER1/2 based on somewhat old DragonFly source.

Below diff is to make them uptodate with the current DragonFly's fstyp HAMMER1/2 code base without making changes to other fstyp files (note that DragonFly does this in their fstyp).

This makes easier to sync up with DragonFly's HAMMER1/2 detection support in the future.

Git format diff
https://www.dragonflybsd.org/~tkusumi/diff/freebsd/0001-fstyp-Sync-HAMMER1-2-support-with-DragonFly.patch
Comment 1 Pedro F. Giffuni freebsd_committer freebsd_triage 2020-02-06 17:56:43 UTC 
Looks good to me, thank you!
FWIW, I am considering dropping the headers and using only the required structures directly.
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-02-06 18:04:54 UTC 
A commit references this bug:

Author: pfg
Date: Thu Feb  6 18:04:16 UTC 2020
New revision: 357631
URL: https://svnweb.freebsd.org/changeset/base/357631

Log:
  fstyp: sync HAMMER1/2 detection support with DragonFly BSD.

  Submitted by:	Tomohiro Kusumi
  PR:		243929

Changes:
  head/usr.sbin/fstyp/hammer.c
  head/usr.sbin/fstyp/hammer2.c
Comment 3 Conrad Meyer freebsd_committer freebsd_triage 2020-02-06 23:29:53 UTC 
Thanks!