Bug 244033 - Undefined symbol "cap_rights_contains@FBSD_1.3" after r357452
Summary: Undefined symbol "cap_rights_contains@FBSD_1.3" after r357452
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Guzik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-11 00:09 UTC by Jan Kokemüller
Modified: 2020-02-11 18:20 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Kokemüller 2020-02-11 00:09:59 UTC 
r357452 turned "cap_rights_contains" into a static inline function. This made it disappear from libc.so and my program complains:

Undefined symbol "cap_rights_contains@FBSD_1.3"

I wonder if this function is still supposed to be there for compatibility with older binaries.
Comment 1 Jan Kokemüller 2020-02-11 00:18:46 UTC 
Hm, r357471 could also be the problem.
Comment 2 Mateusz Guzik freebsd_committer freebsd_triage 2020-02-11 05:59:01 UTC 
Thanks for the report. I'm going to restore it.
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-02-11 18:14:26 UTC 
A commit references this bug:

Author: mjg
Date: Tue Feb 11 18:13:54 UTC 2020
New revision: 357766
URL: https://svnweb.freebsd.org/changeset/base/357766

Log:
  capsicum: restore the cap_rights_contains symbol

  It is expected to be provided by libc.

  PR:		244033
  Reported by:	 Jan Kokemueller

Changes:
  head/sys/kern/subr_capability.c
  head/sys/sys/capsicum.h