Bug 244302 - WITHOUT_LZMA_SUPPORT has no effect
Summary: WITHOUT_LZMA_SUPPORT has no effect
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Warner Losh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-22 08:35 UTC by Xin LI
Modified: 2021-07-16 18:30 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xin LI freebsd_committer freebsd_triage 2020-02-22 08:35:10 UTC 
src.conf option WITHOUT_LZMA_SUPPORT has no effect.  The library and the xz utilities are always built.  There is no use of MK_LZMA_SUPPORT throught the whole base system.

I have added support for MK_LZMA_SUPPORT in gzip(1), and on amd64 -CURRENT, the version without LZMA support is only 8KiB smaller than the version with it.  The shared object itself is about 180KiB.

I think if the goal is to support it, we should teach build system about it (e.g. don't build LZMA libraries, etc.), but personally I don't see much point of doing this so perhaps we should just remove this option.
Comment 1 Xin LI freebsd_committer freebsd_triage 2020-02-22 08:39:10 UTC 
-> imp@ for triage.

The option was added in r263997 and the sole user was grep.  Compression support was removed in r332995 by bapt@.
Comment 2 Warner Losh freebsd_committer freebsd_triage 2021-07-07 04:08:29 UTC 
Sorry for the delay... Where'd 2020 go to anyway?

I concur. This option is obsolete, and should go away...

https://reviews.freebsd.org/D31088
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-07-10 16:54:24 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=d8514fa6f1b0b9824b169c5ab66f37713b303c57

commit d8514fa6f1b0b9824b169c5ab66f37713b303c57
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2021-07-10 16:52:12 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2021-07-10 16:53:35 +0000

    mk: LZMA_SUPPORT is unused

    Retire LZMA_SUPPORT. It's unused since r332995.

    Reviewed by:            delphij
    PR:                     244302
    Sponsored by:           Netflix
    Differential Revision:  https://reviews.freebsd.org/D31088

 share/man/man5/src.conf.5                       | 4 +---
 share/mk/src.opts.mk                            | 1 -
 tools/build/options/WITHOUT_LZMA_SUPPORT (gone) | 2 --
 3 files changed, 1 insertion(+), 6 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-07-16 18:30:58 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=9148a80a65463c40e5e20e861fed9669e4cd0c95

commit 9148a80a65463c40e5e20e861fed9669e4cd0c95
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2021-07-10 16:52:12 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2021-07-16 18:28:44 +0000

    mk: LZMA_SUPPORT is unused

    Retire LZMA_SUPPORT. It's unused since r332995.

    Reviewed by:            delphij
    PR:                     244302
    Sponsored by:           Netflix
    Differential Revision:  https://reviews.freebsd.org/D31088

    (cherry picked from commit d8514fa6f1b0b9824b169c5ab66f37713b303c57)

 share/man/man5/src.conf.5                       | 4 +---
 share/mk/src.opts.mk                            | 1 -
 tools/build/options/WITHOUT_LZMA_SUPPORT (gone) | 2 --
 3 files changed, 1 insertion(+), 6 deletions(-)