lib.libproc.proc_test.symbol_lookup lib.msun.ctrig_test.test_inf_inputs started failing after llvm10 import: https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14539/ Console output: https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14539/testReport/junit/lib.libproc/proc_test/symbol_lookup/ https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14539/testReport/junit/lib.msun/ctrig_test/test_inf_inputs/ So in i386: https://ci.freebsd.org/job/FreeBSD-head-i386-test/8648/
dim: can you help checking these?
A commit references this bug: Author: lwhsu Date: Wed Mar 11 12:43:55 UTC 2020 New revision: 358887 URL: https://svnweb.freebsd.org/changeset/base/358887 Log: Temporarily skip 2 failing tests after llvm10 import PR: 244732 Sponsored by: The FreeBSD Foundation Changes: head/lib/libproc/tests/proc_test.c head/lib/msun/tests/ctrig_test.c
I don't know how the symbols don't match, but they obviously don't in gdb: $ gdb /usr/tests/lib/libproc/proc_test GNU gdb (GDB) 9.1 [GDB v9.1 for FreeBSD] Copyright (C) 2020 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-portbld-freebsd13.0". Type "show configuration" for configuration details. For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>. Find the GDB manual and other documentation resources online at: <http://www.gnu.org/software/gdb/documentation/>. For help, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from proc_test... Reading symbols from /usr/lib/debug//usr/tests/lib/libproc/proc_test.debug... (gdb) set args symbol_lookup (gdb) b 143 (gdb) p *sym $4 = {st_name = 3876, st_info = 18 '\022', st_other = 0 '\000', st_shndx = 11, st_value = 34361885776, st_size = 6} (gdb) p tsym $5 = {st_name = 2377, st_info = 2 '\002', st_other = 2 '\002', st_shndx = 11, st_value = 34361879648, st_size = 8427} (gdb) p symname $6 = 0x2011d2 "r_debug_state" CCing @markj, since this looks like it's broken.
The ctrig_test issue looks more concerning. I think the new code isn't properly raising floating point exceptions with ctrig(3) and llvm10.
(In reply to Enji Cooper from comment #4) I have been diving into the ctrig issue, and it appears to be a side-effect of https://reviews.llvm.org/rL372009. It seems that now ctanh() and ctanhf() can have FE_INVALID set after calling them with {inf,inf}. But this code and the way it works is very obtuse. I'm still analyzing it.
A commit references this bug: Author: lwhsu Date: Thu May 7 20:27:32 UTC 2020 New revision: 360797 URL: https://svnweb.freebsd.org/changeset/base/360797 Log: MFC r358887: Temporarily skip 2 failing tests after llvm10 import PR: 244732 Sponsored by: The FreeBSD Foundation Changes: _U stable/12/ stable/12/lib/libproc/tests/proc_test.c stable/12/lib/msun/tests/ctrig_test.c
I'm looking at the libproc test failure now.
A commit references this bug: Author: lwhsu Date: Mon May 11 22:17:25 UTC 2020 New revision: 360938 URL: https://svnweb.freebsd.org/changeset/base/360938 Log: MFC r358887 (partially): Temporarily skip 2 failing tests after llvm10 import The DDifference of the original revision to -head is only lib.msun.ctrig_test.test_inf_inputs skipped. PR: 244732 Sponsored by: The FreeBSD Foundation Changes: _U stable/11/ stable/11/lib/msun/tests/ctrig_test.c
A commit references this bug: Author: markj Date: Tue May 12 17:00:47 UTC 2020 New revision: 360979 URL: https://svnweb.freebsd.org/changeset/base/360979 Log: librtld_db: Fix shlib mapping offsets. kve_offset gives the offset into the backing file, which is not what we want since different segments may map the same page. Use the base of the mapping to determine the offset exported by librtld_db instead. PR: 244732 Reported by: Jenkins, Nicol? Mazzucato <nicomazz97@gmail.com> MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Changes: head/lib/librtld_db/rtld_db.c
A commit references this bug: Author: markj Date: Tue May 12 17:05:56 UTC 2020 New revision: 360980 URL: https://svnweb.freebsd.org/changeset/base/360980 Log: Re-enable proc_test:symbol_lookup after r360979. PR: 244732 MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Changes: head/lib/libproc/tests/proc_test.c
A commit references this bug: Author: markj Date: Tue May 26 14:05:38 UTC 2020 New revision: 361504 URL: https://svnweb.freebsd.org/changeset/base/361504 Log: MFC r360979: librtld_db: Fix shlib mapping offsets. PR: 244732 Changes: _U stable/12/ stable/12/lib/librtld_db/rtld_db.c
A commit references this bug: Author: markj Date: Tue May 26 14:06:07 UTC 2020 New revision: 361505 URL: https://svnweb.freebsd.org/changeset/base/361505 Log: MFC r360980: Re-enable proc_test:symbol_lookup after r360979. PR: 244732 Changes: _U stable/12/ stable/12/lib/libproc/tests/proc_test.c
*** Bug 244823 has been marked as a duplicate of this bug. ***
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=ac76bc1145dd7f4476e5d982ce8f355f71015713 commit ac76bc1145dd7f4476e5d982ce8f355f71015713 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2021-02-09 21:06:51 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2021-02-09 21:07:05 +0000 Fix lib/msun's ctrig_test/test_inf_inputs test case with clang >= 10 This sprinkles a few strategic volatiles in an attempt to defeat clang's optimization interfering with the expected floating-point exception flags. Reported by: lwhsu PR: 244732 MFC after: 3 days lib/msun/src/s_ccoshf.c | 2 +- lib/msun/src/s_ctanh.c | 2 +- lib/msun/src/s_ctanhf.c | 2 +- lib/msun/tests/ctrig_test.c | 3 --- 4 files changed, 3 insertions(+), 6 deletions(-)
A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=5bc11b95b87c931d45dee0e3f27ce1455f59a460 commit 5bc11b95b87c931d45dee0e3f27ce1455f59a460 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2021-02-12 20:45:33 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2021-02-12 20:48:03 +0000 test_inf_inputs: Use atf_tc_expect_fail() instead of atf_tc_skip() Reviewed By: lwhsu Differential Revision: https://reviews.freebsd.org/D28396 (cherry picked from commit 4d2edf3af1dbd8a3e7cf1b22343a1ecfc2dd41ba) Fix lib/msun's ctrig_test/test_inf_inputs test case with clang >= 10 This sprinkles a few strategic volatiles in an attempt to defeat clang's optimization interfering with the expected floating-point exception flags. Reported by: lwhsu PR: 244732 (cherry picked from commit ac76bc1145dd7f4476e5d982ce8f355f71015713) lib/msun/src/s_ccoshf.c | 2 +- lib/msun/src/s_ctanh.c | 2 +- lib/msun/src/s_ctanhf.c | 2 +- lib/msun/tests/ctrig_test.c | 3 --- 4 files changed, 3 insertions(+), 6 deletions(-)
A commit in branch stable/12 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=f2a88e744701de1b37d7463828f2147f96e39d58 commit f2a88e744701de1b37d7463828f2147f96e39d58 Author: Alex Richardson <arichardson@FreeBSD.org> AuthorDate: 2021-01-29 09:28:40 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2021-02-12 20:50:28 +0000 test_inf_inputs: Use atf_tc_expect_fail() instead of atf_tc_skip() Reviewed By: lwhsu Differential Revision: https://reviews.freebsd.org/D28396 (cherry picked from commit 4d2edf3af1dbd8a3e7cf1b22343a1ecfc2dd41ba) Fix lib/msun's ctrig_test/test_inf_inputs test case with clang >= 10 This sprinkles a few strategic volatiles in an attempt to defeat clang's optimization interfering with the expected floating-point exception flags. Reported by: lwhsu PR: 244732 (cherry picked from commit ac76bc1145dd7f4476e5d982ce8f355f71015713) lib/msun/src/s_ccoshf.c | 2 +- lib/msun/src/s_ctanh.c | 2 +- lib/msun/src/s_ctanhf.c | 2 +- lib/msun/tests/ctrig_test.c | 3 --- 4 files changed, 3 insertions(+), 6 deletions(-)
A commit in branch stable/11 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=ca9df934a5520f9692eb6808b1d02c0d3f1b927a commit ca9df934a5520f9692eb6808b1d02c0d3f1b927a Author: Alex Richardson <arichardson@FreeBSD.org> AuthorDate: 2021-01-29 09:28:40 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2021-02-12 20:53:02 +0000 test_inf_inputs: Use atf_tc_expect_fail() instead of atf_tc_skip() Reviewed By: lwhsu Differential Revision: https://reviews.freebsd.org/D28396 (cherry picked from commit 4d2edf3af1dbd8a3e7cf1b22343a1ecfc2dd41ba) Fix lib/msun's ctrig_test/test_inf_inputs test case with clang >= 10 This sprinkles a few strategic volatiles in an attempt to defeat clang's optimization interfering with the expected floating-point exception flags. Reported by: lwhsu PR: 244732 (cherry picked from commit ac76bc1145dd7f4476e5d982ce8f355f71015713) lib/msun/src/s_ccoshf.c | 2 +- lib/msun/src/s_ctanh.c | 2 +- lib/msun/src/s_ctanhf.c | 2 +- lib/msun/tests/ctrig_test.c | 3 --- 4 files changed, 3 insertions(+), 6 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=e2157cd0000f6dbb6465d7a885f2dcfd4d3596cb commit e2157cd0000f6dbb6465d7a885f2dcfd4d3596cb Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2021-11-05 21:26:16 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2021-11-05 21:27:20 +0000 Partially revert ac76bc1145dd because it is no longer necessary In ac76bc1145dd, I added a few volatiles to work around ctrig_test failures with {inf,inf}. This is not necessary anymore now, since in 3b00222f156d we added -fp-exception-behavior=maytrap for clang >= 10 in libm's Makefile. (The flag tells clang to use stricter floating point semantics, which libm depends on.) PR: 244732, 254911 Fixes: ac76bc1145dd MFC after: 3 days lib/msun/src/s_ccoshf.c | 2 +- lib/msun/src/s_ctanh.c | 2 +- lib/msun/src/s_ctanhf.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=188a9517358e9dba97fb8dd682540bc915beed40 commit 188a9517358e9dba97fb8dd682540bc915beed40 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2021-11-05 21:26:16 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2021-11-08 21:00:47 +0000 Partially revert ac76bc1145dd because it is no longer necessary In ac76bc1145dd, I added a few volatiles to work around ctrig_test failures with {inf,inf}. This is not necessary anymore now, since in 3b00222f156d we added -fp-exception-behavior=maytrap for clang >= 10 in libm's Makefile. (The flag tells clang to use stricter floating point semantics, which libm depends on.) PR: 244732, 254911 Fixes: ac76bc1145dd (cherry picked from commit e2157cd0000f6dbb6465d7a885f2dcfd4d3596cb) lib/msun/src/s_ccoshf.c | 2 +- lib/msun/src/s_ctanh.c | 2 +- lib/msun/src/s_ctanhf.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
A commit in branch stable/12 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=d92735449c54a15f6f048ccefd61a9583d1935d0 commit d92735449c54a15f6f048ccefd61a9583d1935d0 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2021-11-05 21:26:16 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2021-11-08 21:12:26 +0000 Partially revert ac76bc1145dd because it is no longer necessary In ac76bc1145dd, I added a few volatiles to work around ctrig_test failures with {inf,inf}. This is not necessary anymore now, since in 3b00222f156d we added -fp-exception-behavior=maytrap for clang >= 10 in libm's Makefile. (The flag tells clang to use stricter floating point semantics, which libm depends on.) PR: 244732, 254911 Fixes: ac76bc1145dd (cherry picked from commit e2157cd0000f6dbb6465d7a885f2dcfd4d3596cb) lib/msun/src/s_ccoshf.c | 2 +- lib/msun/src/s_ctanh.c | 2 +- lib/msun/src/s_ctanhf.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
A commit in branch stable/11 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=ca7ffd26b3b56cf94f8ee6d373d1cb47eb046fe0 commit ca7ffd26b3b56cf94f8ee6d373d1cb47eb046fe0 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2021-11-05 21:26:16 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2021-11-08 21:14:41 +0000 Partially revert ac76bc1145dd because it is no longer necessary In ac76bc1145dd, I added a few volatiles to work around ctrig_test failures with {inf,inf}. This is not necessary anymore now, since in 3b00222f156d we added -fp-exception-behavior=maytrap for clang >= 10 in libm's Makefile. (The flag tells clang to use stricter floating point semantics, which libm depends on.) PR: 244732, 254911 Fixes: ac76bc1145dd (cherry picked from commit e2157cd0000f6dbb6465d7a885f2dcfd4d3596cb) lib/msun/src/s_ccoshf.c | 2 +- lib/msun/src/s_ctanh.c | 2 +- lib/msun/src/s_ctanhf.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)