Bug 245159 - [PATCH] am335x pmic option ti,pmic-shutdown-controller
Summary: [PATCH] am335x pmic option ti,pmic-shutdown-controller
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: arm (show other bugs)
Version: 12.1-STABLE
Hardware: arm Any
: --- Affects Only Me
Assignee: Emmanuel Vadot
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-29 10:19 UTC by Oskar Holmlund
Modified: 2020-08-17 06:42 UTC (History)
2 users (show)

See Also:

Attachments
Honor ti,pmic-shutdown-controller option in DTS (1.50 KB, text/plain)
2020-03-29 10:19 UTC, Oskar Holmlund 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oskar Holmlund 2020-03-29 10:19:23 UTC 
Created attachment 212824 [details]
Honor ti,pmic-shutdown-controller option in DTS

Tested on stable r359316 @ Sleep mode on custom hw, Power off on BBB and PB

OFF bit [1] in status register control the pmic behaviour when PWR_EN pin is pulled low. On most AM335x hardware [beaglebone *] the desired behaviour are infact power off due to some hardware designs - read more in the comments around pmic in sys/gnu/dts/arm/am335x-bone-common.dtsi

This patch let the device-tree decide with ti,pmic-shutdown-controller[2] the state of off bit in status register. 

[1] 8.6.12 table 12 http://www.ti.com/lit/ds/symlink/tps65217.pdf

[2] Documentation/devicetree/bindings/regulator/tps65217.txt
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-04-11 15:52:22 UTC 
A commit references this bug:

Author: manu
Date: Sat Apr 11 15:52:08 UTC 2020
New revision: 359806
URL: https://svnweb.freebsd.org/changeset/base/359806

Log:
  arm: am335x: Honor pmic option ti,pmic-shutdown-controller

  Honor ti,pmic-shutdown-controller option in DTS

  Tested on stable r359316 @ Sleep mode on custom hw, Power off on BBB and PB

  OFF bit [1] in status register control the pmic behaviour when PWR_EN pin
  is pulled low.
  On most AM335x hardware [beaglebone *] the desired behaviour are in fact
  power off due to some hardware designs - read more in the comments around
  pmic in sys/gnu/dts/arm/am335x-bone-common.dtsi

  This patch let the device-tree decide with ti,pmic-shutdown-controller[2]
  the state of off bit in status register.

  [1] 8.6.12 table 12 http://www.ti.com/lit/ds/symlink/tps65217.pdf

  [2] Documentation/devicetree/bindings/regulator/tps65217.txt

  PR:		245159
  Submitted by:	Oskar Holmlund <oskar.holmlund@ohdata.se>
  MFC after:	2 weeks

Changes:
  head/sys/arm/ti/am335x/am335x_pmic.c
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-06-19 18:03:20 UTC 
A commit references this bug:

Author: manu
Date: Fri Jun 19 18:02:30 UTC 2020
New revision: 362398
URL: https://svnweb.freebsd.org/changeset/base/362398

Log:
  MFC r359806:

  arm: am335x: Honor pmic option ti,pmic-shutdown-controller

  Honor ti,pmic-shutdown-controller option in DTS

  Tested on stable r359316 @ Sleep mode on custom hw, Power off on BBB and PB

  OFF bit [1] in status register control the pmic behaviour when PWR_EN pin
  is pulled low.
  On most AM335x hardware [beaglebone *] the desired behaviour are in fact
  power off due to some hardware designs - read more in the comments around
  pmic in sys/gnu/dts/arm/am335x-bone-common.dtsi

  This patch let the device-tree decide with ti,pmic-shutdown-controller[2]
  the state of off bit in status register.

  [1] 8.6.12 table 12 http://www.ti.com/lit/ds/symlink/tps65217.pdf

  [2] Documentation/devicetree/bindings/regulator/tps65217.txt

  PR:		245159
  Submitted by:	Oskar Holmlund <oskar.holmlund@ohdata.se>

Changes:
_U  stable/12/
  stable/12/sys/arm/ti/am335x/am335x_pmic.c
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2020-08-17 06:42:05 UTC 
Committed Apr 11 15:52:08 UTC 2020 as r359806.

^Triage: assign to committer that resolved.