Bug 245510 - graphics/libepoxy: make X11 an option
Summary: graphics/libepoxy: make X11 an option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on:
Blocks: 247091
  Show dependency tree / graph
 
Reported: 2020-04-10 17:00 UTC by Val Packett
Modified: 2020-06-14 14:05 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (x11)

Attachments
libepoxy-opt.patch (1.24 KB, patch)
2020-04-10 17:00 UTC, Val Packett 		no flags Details | Diff
libepoxy-opt.patch v2 (1.39 KB, patch)
2020-04-12 18:01 UTC, Val Packett 		no flags Details | Diff
libepoxy X11 opt out v3 (1.15 KB, patch)
2020-06-11 15:50 UTC, Niclas Zeising 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Val Packett 2020-04-10 17:00:49 UTC 
Created attachment 213251 [details]
libepoxy-opt.patch

This patch allows building libepoxy without X11.
Comment 1 Niclas Zeising freebsd_committer freebsd_triage 2020-04-10 23:53:12 UTC 
This adds a ton of complexity for the benefit of not installing two headers.  Can you give an argument for why you think this is needed?  Thanks!
Comment 2 Val Packett 2020-04-11 02:02:03 UTC 
(In reply to Niclas Zeising from comment #1)

It's not about headers, it's making the dependency on libX11 optional. I'm trying to build a Wayland-only system with zero X11 packages. Similarly, it should be possible to build an embedded system that runs e.g. Kodi or RetroArch directly on drm and not have any X libs there either. And to use headless graphics (osmesa) on a server without any x11.
Comment 3 Jan Beich freebsd_committer freebsd_triage 2020-04-11 06:44:47 UTC 
Comment on attachment 213251 [details]
libepoxy-opt.patch

> +.include <bsd.port.options.mk>
> +
> +.if ${PORT_OPTIONS:MX11}
> +PLIST_SUB+= X11=""
> +.else
> +PLIST_SUB+= X11="@comment "
> +.endif
> +

Maybe replace with OPTIONS_SUB=yes
Comment 4 Val Packett 2020-04-12 18:01:35 UTC 
Created attachment 213339 [details]
libepoxy-opt.patch v2

Sure
Comment 5 Jan Beich freebsd_committer freebsd_triage 2020-06-08 19:55:15 UTC 
Can you move USE_GL=gl under X11 option? Otherwise, it fails to build if graphics/libglvnd is built without X11

  ===>   libepoxy-1.5.4 depends on shared library: libGL.so - not found
Comment 6 Niclas Zeising freebsd_committer freebsd_triage 2020-06-11 15:50:13 UTC 
Created attachment 215454 [details]
libepoxy X11 opt out v3

Does this look ok for libglvnd jbeich?
Comment 7 Jan Beich freebsd_committer freebsd_triage 2020-06-12 00:56:49 UTC 
Comment on attachment 215454 [details]
libepoxy X11 opt out v3

Can you move X11_MESON_TRUE X11_MESON_YES after X11_USES and X11_USE? In general, the style in options tries to follow/mimic the global one.

> +#OPTIONS_DEFAULT=	X11

Disabling X11 by default here but not in libglvnd/mesa-libs is pointless.
Comment 8 commit-hook freebsd_committer freebsd_triage 2020-06-14 13:57:54 UTC 
A commit references this bug:

Author: zeising
Date: Sun Jun 14 13:56:58 UTC 2020
New revision: 538741
URL: https://svnweb.freebsd.org/changeset/ports/538741

Log:
  graphics/libepoxy: Make x11 support an option

  Make X11 support in graphics/libepoxy an option, default to on.  This makes
  it possible to build libepoxy with only wayland support.

  PR:		245510
  Submitted by:	Greg V (with minor changes)
  Reviewed by:	jbiech

Changes:
  head/graphics/libepoxy/Makefile
  head/graphics/libepoxy/pkg-plist