Bug 245720 - www/py-django-caching-app-plugins: Remove port as it's broken at runtime since a long time
Summary: www/py-django-caching-app-plugins: Remove port as it's broken at runtime sinc...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL: https://pypi.org/project/django-cachi...
Keywords:
Depends on:
Blocks: 245309
  Show dependency tree / graph
 
Reported: 2020-04-18 10:20 UTC by Kai Knoblich
Modified: 2020-04-18 11:51 UTC (History)
1 user (show)

See Also:
ports: maintainer-feedback+

Attachments
delete-py-django-caching-app-plugins.patch (3.78 KB, patch)
2020-04-18 10:20 UTC, Kai Knoblich 		ports: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer freebsd_triage 2020-04-18 10:20:34 UTC 
Created attachment 213529 [details]
delete-py-django-caching-app-plugins.patch

Hi,

it seems that www/py-django-caching-app-plugins is broken at runtime [1] since ports r469560 because "SortedDict" was deprecated with Django 1.7 and got removed in Django 1.9.

There are no newer updates available and the package wasn't updated by upstream since 2014. Hence it might be a good idea to remove the port without deprecating/expiring it first.

--

[1] Errors that are emitted when trying to import the package:

- Using Python 2.7 with Django 1.11:

> >>> import app_plugins
> Traceback (most recent call last):
>   File "<stdin>", line 1, in <module>
>   File "/usr/local/lib/python2.7/site-packages/app_plugins/__init__.py", line 3, in <module>
>     from library import Library
>   File "/usr/local/lib/python2.7/site-packages/app_plugins/library.py", line 3, in <module>
>     from django.utils.datastructures import SortedDict
> ImportError: cannot import name SortedDict

- The code isn't compatible with recent Python versions as well when using Python 3.7 with Django 1.11 or 2.2:

> >>> import app_plugins
> Traceback (most recent call last):
>   File "<stdin>", line 1, in <module>
>   File "/usr/local/lib/python3.7/site-packages/app_plugins/__init__.py", line 3, in <module>
>     from library import Library
> ModuleNotFoundError: No module named 'library'
Comment 1 Kevin Golding 2020-04-18 10:43:16 UTC 
Makes sense. It was included as a dependency for Satchmo which has been deleted now. It was kept around for deprecation period and then missed in the clean up.
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-04-18 11:49:20 UTC 
A commit references this bug:

Author: kai
Date: Sat Apr 18 11:48:37 UTC 2020
New revision: 532026
URL: https://svnweb.freebsd.org/changeset/ports/532026

Log:
  www/py-django-caching-app-plugins: Remove port

  * The port was required as a dependency for www/py-satchmo which is gone
    from the Ports tree since 2016.

    It's also broken at runtime since r469560 when it was switched to
    Django 1.11 because the "SortedDict" class was removed with Django 1.9 and
    the code doesn't work with Python 3 either.

  PR:		245720
  Approved by:	Kevin Golding <ports@caomhin.org> (maintainer)

Changes:
  head/MOVED
  head/www/Makefile
  head/www/py-django-caching-app-plugins/
Comment 3 Kai Knoblich freebsd_committer freebsd_triage 2020-04-18 11:51:37 UTC 
(In reply to Kevin Golding from comment #1)

Ok, the port is deleted. Thank you for the quick feedback!