Bug 245808 - security/keychain: switch to USE_GITHUB
Summary: security/keychain: switch to USE_GITHUB
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-22 01:20 UTC by Koichiro Iwao
Modified: 2020-04-22 15:00 UTC (History)
1 user (show)

See Also:
garga: maintainer-feedback+

Attachments
patch (1.43 KB, text/plain)
2020-04-22 01:20 UTC, Koichiro Iwao 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Koichiro Iwao freebsd_committer freebsd_triage 2020-04-22 01:20:43 UTC 
Created attachment 213658 [details]
patch

The distfile is no longer found at:
http://www.funtoo.org/archive/keychain/keychain-2.8.5.tar.bz2

As mentioned in WWW, the distfile can be found on GitHub.
> The latest release of Keychain can be found on the keychain GitHub release page. 

While here, switch WWW to https.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2020-04-22 08:21:45 UTC 
You don't need to define GH_PROJECT since it defaults to ${PORTNAME} according to https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#makefile-master_sites-github-description
Comment 2 Koichiro Iwao freebsd_committer freebsd_triage 2020-04-22 13:03:55 UTC 
(In reply to daniel.engberg.lists from comment #1)
Indeed, thanks!
Comment 3 Renato Botelho freebsd_committer freebsd_triage 2020-04-22 13:57:19 UTC 
Approved.  Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-04-22 14:59:48 UTC 
A commit references this bug:

Author: meta
Date: Wed Apr 22 14:59:21 UTC 2020
New revision: 532482
URL: https://svnweb.freebsd.org/changeset/ports/532482

Log:
  security/keychain: switch to USE_GITHUB

  The distfile is no longer found at:
  http://www.funtoo.org/archive/keychain/keychain-2.8.5.tar.bz2

  As mentioned in WWW, the distfile can be found on GitHub.
  > The latest release of Keychain can be found on the keychain GitHub release page.

  While here, switch WWW to https and changed to nice-look URL.

  PR:		245808
  Submitted by:	meta (myself)
  Reviewed by:	daniel.engberg.lists@pyret.net
  Approved by:	garga (maintainer)

Changes:
  head/security/keychain/Makefile
  head/security/keychain/distinfo
  head/security/keychain/pkg-descr
Comment 5 Koichiro Iwao freebsd_committer freebsd_triage 2020-04-22 15:00:45 UTC 
Committed with a minor change pointed out by daniel.engberg.lists@pyret.net.