Bug 245898 - databases/rrdtool: rrdtool resize does not work on zfs
Summary: databases/rrdtool: rrdtool resize does not work on zfs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Niclas Zeising
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-25 09:11 UTC by Tomohiro Hosaka
Modified: 2020-06-15 17:45 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (zeising)

Attachments
patch for rrdtool-1.7.2_2 (504 bytes, text/plain)
2020-04-25 09:11 UTC, Tomohiro Hosaka 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomohiro Hosaka 2020-04-25 09:11:14 UTC 
Created attachment 213772 [details]
patch for rrdtool-1.7.2_2

rrdtool resize does not work on zfs.

# rrdtool resize source.rrd 0 GROW 1
ERROR: Can't create 'resize.rrd': No error: 0
# ls -l resize.rrd
-rw-r--r--   1 root  wheel         0  4月 25 15:39 resize.rrd

The cause was that posix_fallocate returned EINVAL.

I created a patch.
Comment 1 Niclas Zeising freebsd_committer freebsd_triage 2020-04-27 06:37:33 UTC 
Hi!
This patch belongs upstream, can you submit it there?
Comment 2 Tomohiro Hosaka 2020-04-27 07:05:38 UTC 
Hi.

I have submitted. https://github.com/oetiker/rrdtool-1.x/issues/1082
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-06-14 15:23:07 UTC 
A commit references this bug:

Author: zeising
Date: Sun Jun 14 15:22:25 UTC 2020
New revision: 538811
URL: https://svnweb.freebsd.org/changeset/ports/538811

Log:
  databases/rrdtool: Fix resize on ZFS

  Add an upstream patch that fixes resize on ZFS.  Since ZFS does not support
  posix_fallocate(), returning EINVAL, the patch simply ignores this error
  from posix_fallocate().

  PR:		245898
  Reported by:	Tomohiro Hosaka
  MFH:		2020Q2

Changes:
  head/databases/rrdtool/Makefile
  head/databases/rrdtool/files/patch-8829fa7.c
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-06-15 17:45:00 UTC 
A commit references this bug:

Author: zeising
Date: Mon Jun 15 17:44:21 UTC 2020
New revision: 538923
URL: https://svnweb.freebsd.org/changeset/ports/538923

Log:
  MFH: r538811

  databases/rrdtool: Fix resize on ZFS

  Add an upstream patch that fixes resize on ZFS.  Since ZFS does not support
  posix_fallocate(), returning EINVAL, the patch simply ignores this error
  from posix_fallocate().

  PR:		245898
  Reported by:	Tomohiro Hosaka

  Approved by:	ports-secteam (joenum)

Changes:
_U  branches/2020Q2/
  branches/2020Q2/databases/rrdtool/Makefile
  branches/2020Q2/databases/rrdtool/files/patch-8829fa7.c