Bug 246080 - vt options mismatch
Summary: vt options mismatch
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Mark Johnston
URL:
Keywords: patch, vt
Depends on:
Blocks:
 
Reported: 2020-05-01 10:11 UTC by David Marec
Modified: 2020-06-08 21:52 UTC (History)
4 users (show)

See Also:

Attachments
option VT_FB_DEFAULT_WIDTH replacement (990 bytes, patch)
2020-05-01 10:11 UTC, David Marec 		no flags Details | Diff
man vt + kernel NOTES + kernel options (1.51 KB, text/plain)
2020-05-30 18:14 UTC, David Marec 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Marec 2020-05-01 10:11:00 UTC 
Created attachment 213980 [details]
option VT_FB_DEFAULT_WIDTH replacement

The commit 
https://svnweb.freebsd.org/base?view=revision&revision=303312 
replaced the  «framebuffer max size» id from `VT_FB_DEFAULT_WIDTH` to `VT_FB_MAX_WIDTH`.

Unless this tag  has been also switched in `sys/conf/options`, this  configuration option will never be populated.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2020-05-24 21:45:30 UTC 
Notify original committer.
Comment 2 Conrad Meyer freebsd_committer freebsd_triage 2020-05-29 17:57:45 UTC 
Ah, I had no idea they were config options.  Bug is present in CURRENT; patch is missing (trivial) sys/conf/NOTES update.
Comment 3 David Marec 2020-05-30 18:14:28 UTC 
Created attachment 215068 [details]
man vt + kernel NOTES + kernel options

Correct. Here is a path that reviews kernel NOTES.
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-06-04 16:05:31 UTC 
A commit references this bug:

Author: markj
Date: Thu Jun  4 16:05:25 UTC 2020
New revision: 361792
URL: https://svnweb.freebsd.org/changeset/base/361792

Log:
  Update vt(4) config option names to chase r303043.

  PR:		246080
  Submitted by:	David Marec <david@lapinbilly.eu>
  MFC after:	1 week

Changes:
  head/share/man/man4/vt.4
  head/sys/conf/NOTES
  head/sys/conf/options
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-06-08 21:39:33 UTC 
A commit references this bug:

Author: markj
Date: Mon Jun  8 21:38:53 UTC 2020
New revision: 361942
URL: https://svnweb.freebsd.org/changeset/base/361942

Log:
  MFC r361792:
  Update vt(4) config option names to chase r303043.

  PR:	246080

Changes:
_U  stable/12/
  stable/12/share/man/man4/vt.4
  stable/12/sys/conf/NOTES
  stable/12/sys/conf/options
Comment 6 Mark Johnston freebsd_committer freebsd_triage 2020-06-08 21:52:21 UTC 
Thanks for the report and the patch.