Bug 246140 - www/squid-devel: resurrect and upgrade to 5.0.2
Summary: www/squid-devel: resurrect and upgrade to 5.0.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-03 11:02 UTC by Pavel Timofeev
Modified: 2020-05-05 13:39 UTC (History)
1 user (show)

See Also:

Attachments
squid-devel.diff (187.04 KB, patch)
2020-05-03 11:02 UTC, Pavel Timofeev 		timp87: maintainer-approval+
Details | Diff
squid-devel.shar (121.18 KB, text/plain)
2020-05-03 11:02 UTC, Pavel Timofeev 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Timofeev 2020-05-03 11:02:07 UTC 
Created attachment 214053 [details]
squid-devel.diff

Resurrect www/squid-devel as 5.x came into beta state
PR that should be committed first:
- https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246138
- https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246139

I strongly recommend you to review release note http://www.squid-cache.org/Versions/v5/squid-5.0.2-RELEASENOTES.html if you decide to upgrade

The most notable change for me was BDB deprecation in behalf of TDB.

Know issues:
- https://bugs.squid-cache.org/show_bug.cgi?id=5042
Comment 1 Pavel Timofeev 2020-05-03 11:02:47 UTC 
Created attachment 214054 [details]
squid-devel.shar

Attaching shar also
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2020-05-03 16:03:34 UTC 
Committed, thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-05-03 16:03:51 UTC 
A commit references this bug:

Author: pi
Date: Sun May  3 16:03:31 UTC 2020
New revision: 533791
URL: https://svnweb.freebsd.org/changeset/ports/533791

Log:
  www/squid-devel: resurrect and upgrade to 5.0.2

  - it is strongly recommended to review release notes
    http://www.squid-cache.org/Versions/v5/squid-5.0.2-RELEASENOTES.html
    if you decide to upgrade
  - The most notable change for maintainer was BDB deprecation in behalf of TDB
  - Know upstream issues:
    https://bugs.squid-cache.org/show_bug.cgi?id=5042

  PR:		246140
  Submitted by:	Pavel Timofeev <timp87@gmail.com> (maintainer)

Changes:
  head/MOVED
  head/www/Makefile
  head/www/squid-devel/
  head/www/squid-devel/Makefile
  head/www/squid-devel/distinfo
  head/www/squid-devel/files/patch-configure
  head/www/squid-devel/files/patch-src-cf.data.pre
  head/www/squid-devel/files/patch-src_enums.h
  head/www/squid-devel/pkg-plist
Comment 4 Pavel Timofeev 2020-05-05 12:21:30 UTC 
(In reply to Kurt Jaeger from comment #2)
I'm sorry. I've just noticed some patches are missing in files directory.
That's my faulty diff. Shar file has everything in it.
How should I handle this? Create new diff against already committed port?
Comment 5 Pavel Timofeev 2020-05-05 12:24:14 UTC 
(In reply to timp87 from comment #4)
Missing files are 
- patch-src_acl_external_session_ext__session__acl.cc
- patch-src_acl_external_eDirectory__userip_ext__edirectory__userip__acl.cc
Comment 6 commit-hook freebsd_committer freebsd_triage 2020-05-05 13:30:48 UTC 
A commit references this bug:

Author: pi
Date: Tue May  5 13:29:51 UTC 2020
New revision: 534085
URL: https://svnweb.freebsd.org/changeset/ports/534085

Log:
  www/squid-devel: add missing patches

  - missed during the initial commit

  PR:		246140
  Submitted by:	Pavel Timofeev <timp87@gmail.com> (maintainer)
  Pointy hat to:	pi

Changes:
  head/www/squid-devel/files/patch-src_acl_external_eDirectory__userip_ext__edirectory__userip__acl.cc
  head/www/squid-devel/files/patch-src_acl_external_session_ext__session__acl.cc
Comment 7 Kurt Jaeger freebsd_committer freebsd_triage 2020-05-05 13:32:37 UTC 
Your shar was fine, I failed to svn add them in time for the commit 8-( Fixed.
Comment 8 Pavel Timofeev 2020-05-05 13:39:17 UTC 
(In reply to Kurt Jaeger from comment #7)
I highly appreciate that!