Bug 247033 - comms/opencbm: fix some issues
Summary: comms/opencbm: fix some issues
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-06 15:11 UTC by Felix Palmen
Modified: 2020-06-06 15:35 UTC (History)
1 user (show)

See Also:

Attachments
fix CC, allow custom CGLAGS (1.35 KB, patch)
2020-06-06 15:11 UTC, Felix Palmen 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Palmen freebsd_committer freebsd_triage 2020-06-06 15:11:45 UTC 
Created attachment 215295 [details]
fix CC, allow custom CGLAGS

Review on github revealed I accidentally hardcoded cc for $CC, this is fixed with attached patch. Also added a line to Makefile.inc so CFLAGS are passed to OpenCBM's build system.

Build tests pending.
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-06-06 15:34:39 UTC 
A commit references this bug:

Author: dinoex
Date: Sat Jun  6 15:34:13 UTC 2020
New revision: 538099
URL: https://svnweb.freebsd.org/changeset/ports/538099

Log:
  - fix CC, allow custom CFLAGS
  PR:		247033
  Submitted by:	Felix Palmen

Changes:
  head/comms/opencbm/Makefile
  head/comms/opencbm/Makefile.inc
  head/comms/opencbm-plugin-xa1541/Makefile
Comment 2 Dirk Meyer freebsd_committer freebsd_triage 2020-06-06 15:35:38 UTC 
Committed, Thanks.