Bug 247740 - net-mgmt/thanos: thanos binary has no version description
Summary: net-mgmt/thanos: thanos binary has no version description
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Larry Rosenman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-03 13:00 UTC by Florian Bauer
Modified: 2020-07-07 18:53 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (ler)

Attachments
v1 (717 bytes, patch)
2020-07-03 16:58 UTC, Mikael Urankar 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Bauer 2020-07-03 13:00:51 UTC 
It looks like the thanos binary has no version description.

"thanos --version" produces:

thanos, version  (branch: , revision: )
  build user:       
  build date:       
  go version:       go1.14.1
Comment 1 Mikael Urankar freebsd_committer freebsd_triage 2020-07-03 16:58:32 UTC 
Created attachment 216178 [details]
v1

You can use this patch. Not sure if these informations are useful, not good for reproducible builds anyway.
Comment 2 Florian Bauer 2020-07-03 17:37:25 UTC 
Thank you. This patch works for me. Is there a chance for getting this patch into the ports?
Comment 3 Mikael Urankar freebsd_committer freebsd_triage 2020-07-04 07:55:14 UTC 
(In reply to Florian Bauer from comment #2)
It's up to the maintainer to accept/reject the patch.
Comment 4 Florian Bauer 2020-07-04 08:47:39 UTC 
Ok. This would be great. We are using these values (version, build user, ...) for custom puppet facts and some other automation processes.
Comment 5 Larry Rosenman freebsd_committer freebsd_triage 2020-07-07 17:47:02 UTC 
@Florian: Is there any way to get the git revision and branch automatically?
Comment 6 Mikael Urankar freebsd_committer freebsd_triage 2020-07-07 18:36:57 UTC 
(In reply to Larry Rosenman from comment #5)
No, this is the infos you have when building with the tarball:
thanos, version 0.13.0 (branch: non-git, revision: non-git)
  build user:       mikael@hostname
  build date:       20200707-18:31:22
  go version:       go1.14.4
Comment 7 Larry Rosenman freebsd_committer freebsd_triage 2020-07-07 18:53:17 UTC 
committed, thanks!
Comment 8 commit-hook freebsd_committer freebsd_triage 2020-07-07 18:53:49 UTC 
A commit references this bug:

Author: ler
Date: Tue Jul  7 18:53:00 UTC 2020
New revision: 541446
URL: https://svnweb.freebsd.org/changeset/ports/541446

Log:
  net-mgmt/thanos: add version description to binary.

  PR:		247740
  Submitted by:	florian@fsrv.xyz

Changes:
  head/net-mgmt/thanos/Makefile