Bug 248204 - sysutils/password-store: Implement Wayland clipboard integration from upstream
Summary: sysutils/password-store: Implement Wayland clipboard integration from upstream
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rene Ladan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-23 14:06 UTC by Ashish SHUKLA
Modified: 2020-07-24 04:08 UTC (History)
0 users

See Also:
rene: maintainer-feedback+

Attachments
diff (5.82 KB, patch)
2020-07-23 14:06 UTC, Ashish SHUKLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ashish SHUKLA freebsd_committer freebsd_triage 2020-07-23 14:06:59 UTC 
Created attachment 216701 [details]
diff

As Wayland support for FreeBSD is getting pretty good, it would be nice to have password-store work with it out of the box. Thankfully, upstream has Wayland clipboard integration implemented[1].

Attached diff:

- Imports this patch locally
- While here, fix the portlint issue
- Option is not enabled as default, as Wayland is not as common X11 yet

References:

[1] https://git.zx2c4.com/password-store/commit/?id=b0b784b1a57c0b06936e6f5d6560712b4b810cd3

Thanks!
Comment 1 Rene Ladan freebsd_committer freebsd_triage 2020-07-23 17:05:23 UTC 
Nice idea, I'd say its time for a new upstream release :)
Comment 2 Ashish SHUKLA freebsd_committer freebsd_triage 2020-07-23 17:31:41 UTC 
(In reply to Rene Ladan from comment #1)

Thanks for approving the diff.

Sorry for being redundant, although I wonder if you're planning to commit it yourself, or expecting me to commit it.
Comment 3 Rene Ladan freebsd_committer freebsd_triage 2020-07-23 19:26:13 UTC 
(In reply to Ashish SHUKLA from comment #2)
Feel free to commit :)
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-07-24 04:07:59 UTC 
A commit references this bug:

Author: ashish
Date: Fri Jul 24 04:07:14 UTC 2020
New revision: 542998
URL: https://svnweb.freebsd.org/changeset/ports/542998

Log:
  - Add a non-default option WAYLAND to build port with wl-clipboard
    integration
  - Pet portlint

  PR:		248204
  Approved by:	rene

Changes:
  head/sysutils/password-store/Makefile
  head/sysutils/password-store/files/extra-patch-wayland-copy-paste.diff
Comment 5 Ashish SHUKLA freebsd_committer freebsd_triage 2020-07-24 04:08:26 UTC 
Committed, thanks!