Bug 248826 - Mk/bsd.gecko.mk: fix build with defined CPUTYPE on powerpc64 (and possibly others)
Summary: Mk/bsd.gecko.mk: fix build with defined CPUTYPE on powerpc64 (and possibly ot...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gecko (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-22 10:28 UTC by Piotr Kubaj
Modified: 2020-09-07 00:58 UTC (History)
2 users (show)

See Also:
pkubaj: maintainer-feedback? (gecko)

Attachments
patch (478 bytes, text/plain)
2020-08-22 10:28 UTC, Piotr Kubaj 		pkubaj: maintainer-approval? (gecko)
 Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2020-08-22 10:28:10 UTC 
Created attachment 217438 [details]
patch

In /etc/make.conf:
CPUTYPE?=power9

When trying to build www/firefox:
make: "/usr/ports/Mk/bsd.gecko.mk" line 265: Malformed conditional (${ARCH:Maarch64} || ${MACHINE_CPU:Msse2})
make: Fatal errors encountered -- cannot continuemake: "/usr/ports/Mk/bsd.gecko.mk" line 265: Malformed conditional (${ARCH:Maarch64} || ${MACHINE_CPU:Msse2})
make: "/usr/ports/Mk/bsd.port.mk" line 4517: warning: duplicate script for target "/tmp/usr/ports/www/firefox/work-make" ignored
make: "/usr/ports/Mk/bsd.port.mk" line 3423: warning: using previous script for "/tmp/usr/ports/www/firefox/work-make" defined here
make: "/usr/ports/Mk/bsd.port.mk" line 5203: warning: duplicate script for target "/tmp/usr/ports/www/firefox/work-make" ignored
make: "/usr/ports/Mk/bsd.port.mk" line 3423: warning: using previous script for "/tmp/usr/ports/www/firefox/work-make" defined here
make: "/usr/ports/Mk/bsd.port.mk" line 5364: warning: duplicate script for target "/tmp/usr/ports/www/firefox/work-make" ignored
make: "/usr/ports/Mk/bsd.port.mk" line 3423: warning: using previous script for "/tmp/usr/ports/www/firefox/work-make" defined here
make: "/usr/ports/Mk/bsd.port.mk" line 5364: warning: duplicate script for target "/tmp/usr/ports/www/firefox/work-make" ignored
make: "/usr/ports/Mk/bsd.port.mk" line 3423: warning: using previous script for "/tmp/usr/ports/www/firefox/work-make" defined here
make: "/usr/ports/Mk/bsd.port.mk" line 5364: warning: duplicate script for target "/tmp/usr/ports/www/firefox/work-make" ignored
make: "/usr/ports/Mk/bsd.port.mk" line 3423: warning: using previous script for "/tmp/usr/ports/www/firefox/work-make" defined here
make: "/usr/ports/Mk/bsd.port.mk" line 5364: warning: duplicate script for target "/tmp/usr/ports/www/firefox/work-make" ignored
make: "/usr/ports/Mk/bsd.port.mk" line 3423: warning: using previous script for "/tmp/usr/ports/www/firefox/work-make" defined here
make: "/usr/ports/Mk/bsd.port.mk" line 5364: warning: duplicate script for target "/tmp/usr/ports/www/firefox/work-make" ignored
make: "/usr/ports/Mk/bsd.port.mk" line 3423: warning: using previous script for "/tmp/usr/ports/www/firefox/work-make" defined here
make: "/usr/ports/Mk/bsd.port.mk" line 5364: warning: duplicate script for target "/tmp/usr/ports/www/firefox/work-make" ignored
make: "/usr/ports/Mk/bsd.port.mk" line 3423: warning: using previous script for "/tmp/usr/ports/www/firefox/work-make" defined here
make: "/usr/ports/Mk/bsd.port.mk" line 5364: warning: duplicate script for target "/tmp/usr/ports/www/firefox/work-make" ignored
make: "/usr/ports/Mk/bsd.port.mk" line 3423: warning: using previous script for "/tmp/usr/ports/www/firefox/work-make" defined here
make: Fatal errors encountered -- cannot continuemake: "/usr/ports/Mk/bsd.gecko.mk" line 265: Malformed conditional (${ARCH:Maarch64} || ${MACHINE_CPU:Msse2})
make: Fatal errors encountered -- cannot continuemake: "/usr/ports/Mk/bsd.gecko.mk" line 265: Malformed conditional (${ARCH:Maarch64} || ${MACHINE_CPU:Msse2})
make: Fatal errors encountered -- cannot continuemake: "/usr/ports/Mk/bsd.gecko.mk" line 265: Malformed conditional (${ARCH:Maarch64} || ${MACHINE_CPU:Msse2})
make: Fatal errors encountered -- cannot continue

Attached patch fixes this issue.
Comment 1 Piotr Kubaj freebsd_committer freebsd_triage 2020-08-22 10:31:48 UTC 
As a sidenote, Rust supports SIMD also for 32-bit ARM:
https://docs.rs/simd/0.2.4/simd/
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-09-07 00:58:20 UTC 
A commit references this bug:

Author: pkubaj
Date: Mon Sep  7 00:58:07 UTC 2020
New revision: 547872
URL: https://svnweb.freebsd.org/changeset/ports/547872

Log:
  Mk/bsd.gecko.mk: fix build with defined CPUTYPE on powerpc64 (and possibly others)

  In /etc/make.conf:
  CPUTYPE?=power9

  When trying to build www/firefox:
  make: "/usr/ports/Mk/bsd.gecko.mk" line 265: Malformed conditional (${ARCH:Maarch64} || ${MACHINE_CPU:Msse2})
  make: Fatal errors encountered -- cannot continuemake: "/usr/ports/Mk/bsd.gecko.mk" line 265: Malformed conditional (${ARCH:Maarch64} || ${MACHINE_CPU:Msse2})
  make: "/usr/ports/Mk/bsd.port.mk" line 4517: warning: duplicate script for target "/tmp/usr/ports/www/firefox/work-make" ignored
  make: "/usr/ports/Mk/bsd.port.mk" line 3423: warning: using previous script for "/tmp/usr/ports/www/firefox/work-make" defined here
  make: "/usr/ports/Mk/bsd.port.mk" line 5203: warning: duplicate script for target "/tmp/usr/ports/www/firefox/work-make" ignored
  make: "/usr/ports/Mk/bsd.port.mk" line 3423: warning: using previous script for "/tmp/usr/ports/www/firefox/work-make" defined here
  make: "/usr/ports/Mk/bsd.port.mk" line 5364: warning: duplicate script for target "/tmp/usr/ports/www/firefox/work-make" ignored
  make: "/usr/ports/Mk/bsd.port.mk" line 3423: warning: using previous script for "/tmp/usr/ports/www/firefox/work-make" defined here
  make: "/usr/ports/Mk/bsd.port.mk" line 5364: warning: duplicate script for target "/tmp/usr/ports/www/firefox/work-make" ignored
  make: "/usr/ports/Mk/bsd.port.mk" line 3423: warning: using previous script for "/tmp/usr/ports/www/firefox/work-make" defined here
  make: "/usr/ports/Mk/bsd.port.mk" line 5364: warning: duplicate script for target "/tmp/usr/ports/www/firefox/work-make" ignored
  make: "/usr/ports/Mk/bsd.port.mk" line 3423: warning: using previous script for "/tmp/usr/ports/www/firefox/work-make" defined here
  make: "/usr/ports/Mk/bsd.port.mk" line 5364: warning: duplicate script for target "/tmp/usr/ports/www/firefox/work-make" ignored
  make: "/usr/ports/Mk/bsd.port.mk" line 3423: warning: using previous script for "/tmp/usr/ports/www/firefox/work-make" defined here
  make: "/usr/ports/Mk/bsd.port.mk" line 5364: warning: duplicate script for target "/tmp/usr/ports/www/firefox/work-make" ignored
  make: "/usr/ports/Mk/bsd.port.mk" line 3423: warning: using previous script for "/tmp/usr/ports/www/firefox/work-make" defined here
  make: "/usr/ports/Mk/bsd.port.mk" line 5364: warning: duplicate script for target "/tmp/usr/ports/www/firefox/work-make" ignored
  make: "/usr/ports/Mk/bsd.port.mk" line 3423: warning: using previous script for "/tmp/usr/ports/www/firefox/work-make" defined here
  make: "/usr/ports/Mk/bsd.port.mk" line 5364: warning: duplicate script for target "/tmp/usr/ports/www/firefox/work-make" ignored
  make: "/usr/ports/Mk/bsd.port.mk" line 3423: warning: using previous script for "/tmp/usr/ports/www/firefox/work-make" defined here
  make: Fatal errors encountered -- cannot continuemake: "/usr/ports/Mk/bsd.gecko.mk" line 265: Malformed conditional (${ARCH:Maarch64} || ${MACHINE_CPU:Msse2})
  make: Fatal errors encountered -- cannot continuemake: "/usr/ports/Mk/bsd.gecko.mk" line 265: Malformed conditional (${ARCH:Maarch64} || ${MACHINE_CPU:Msse2})
  make: Fatal errors encountered -- cannot continuemake: "/usr/ports/Mk/bsd.gecko.mk" line 265: Malformed conditional (${ARCH:Maarch64} || ${MACHINE_CPU:Msse2})
  make: Fatal errors encountered -- cannot continue

  PR:		248826
  Approved by:	gecko (maintainer timeout)

Changes:
  head/Mk/bsd.gecko.mk