Bug 248916 - www/p5-Starman -- provided init script has coding errors
Summary: www/p5-Starman -- provided init script has coding errors
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-perl (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-25 21:11 UTC by James B. Byrne
Modified: 2025-01-26 16:39 UTC (History)
2 users (show)

See Also:
linimon: maintainer-feedback? (perl)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James B. Byrne 2020-08-25 21:11:33 UTC 
The provided init script contains these lines:

starman_enable=${starman_enable-"NO"}
starman_config=${starman_config-"/usr/local/etc/starman.psgi"}
starman_user=${starman_user-"www"}
starman_group=${starman_group-"www"}

The comparison operator is missing the colon : 

These should be 

starman_enable=${starman_enable:-"NO"}
starman_config=${starman_config:-"/usr/local/etc/starman.psgi"}
starman_user=${starman_user:-"www"}
starman_group=${starman_group:-"www"}

I have already corrected this on my suystem so one or more of these may be correct as distributed but the first two are certainly wrong as shipped.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2020-08-26 11:36:08 UTC 
^Triage: fix Summary and assign.
Comment 2 Rene Ladan freebsd_committer freebsd_triage 2021-10-05 18:21:46 UTC 
Maintainer reset.
Comment 3 Rene Ladan freebsd_committer freebsd_triage 2021-10-05 18:21:54 UTC 
Maintainer reset.
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2024-10-19 10:36:22 UTC 
^Triage: assign to current maintainer.
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2025-01-26 16:38:58 UTC 
Committed, thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2025-01-26 16:39:03 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4de1678219ec1c19bfb57b42b56703ed6bdf1c0f

commit 4de1678219ec1c19bfb57b42b56703ed6bdf1c0f
Author:     James B. Byrne <byrnejb@harte-lyne.ca>
AuthorDate: 2025-01-26 16:37:55 +0000
Commit:     Kurt Jaeger <pi@FreeBSD.org>
CommitDate: 2025-01-26 16:37:55 +0000

    www/p5-Starman: fix init script

    PR:             248916

 www/p5-Starman/files/starman.in | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)