Bug 248933 - sys.kern.kern_copyin.kern_copyin fails after somewhere in (r364509, r364542]
Summary: sys.kern.kern_copyin.kern_copyin fails after somewhere in (r364509, r364542]
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: tests (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-testing (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-26 17:11 UTC by Li-Wen Hsu
Modified: 2020-09-06 13:52 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Li-Wen Hsu freebsd_committer freebsd_triage 2020-08-26 17:11:57 UTC
sys.kern.kern_copyin.kern_copyin fails after somewhere in (r364509, r364542]

https://ci.freebsd.org/job/FreeBSD-head-amd64-test/16270/testReport/sys.kern/kern_copyin/kern_copyin/

Changes in (r364509, r364542]:
https://ci.freebsd.org/job/FreeBSD-head-amd64-test/16270/changes
Comment 1 Li-Wen Hsu freebsd_committer freebsd_triage 2020-09-03 08:53:08 UTC
kib: I suspect this is related to introducing LA57 support, but I'm not sure if this is a regression or the test should be fixed. Please help to check. Thanks!
Comment 2 Konstantin Belousov freebsd_committer freebsd_triage 2020-09-03 09:55:48 UTC
(In reply to Li-Wen Hsu from comment #1)
Yes, I believe the test should be adjusted to use VM_MAXUSER_ADDRESS_LA48/LA57 matching the process VA layout.  I will look at it shortly.
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-09-04 12:52:39 UTC
A commit references this bug:

Author: kib
Date: Fri Sep  4 12:52:17 UTC 2020
New revision: 365327
URL: https://svnweb.freebsd.org/changeset/base/365327

Log:
  Fix kern_copyin test.

  Main part is that kern_copyin on amd64 after LA57 should query the top
  of UVA for correct operations. In fact it should started doing that
  after the workaround for AMD bug with IRET in the last user page was
  fixed by reducing UVA by a page.

  Also since we started calculating top of UVA, fix MIPS according to
  the comment.

  Reported by:	lwhsu
  PR:	248933
  Reviewed by:	alc, markj
  Sponsored by:	The FreeBSD Foundation
  Differential revision:	https://reviews.freebsd.org/D26312

Changes:
  head/tests/sys/kern/kern_copyin.c
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-09-04 19:24:55 UTC
A commit references this bug:

Author: lwhsu
Date: Fri Sep  4 19:24:27 UTC 2020
New revision: 365337
URL: https://svnweb.freebsd.org/changeset/base/365337

Log:
  Initialize len to avoid ENOMEM from sysctl(3).

  PR:		248933
  Sponsored by:	The FreeBSD Foundation

Changes:
  head/tests/sys/kern/kern_copyin.c