Bug 248939 - [PATCH] asmc: handle asmc_key_read() error
Summary: [PATCH] asmc: handle asmc_key_read() error
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Mark Johnston
URL: https://github.com/freebsd/freebsd/pu...
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-27 00:19 UTC by Tong Zhang
Modified: 2020-09-03 13:58 UTC (History)
1 user (show)

See Also:

Attachments
0001-asmc-handle-asmc_key_read-error (1.60 KB, application/mbox)
2020-08-27 00:19 UTC, Tong Zhang 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tong Zhang 2020-08-27 00:19:44 UTC 
Created attachment 217562 [details]
0001-asmc-handle-asmc_key_read-error

asmc_key_read() return 1 and 0 only, some callers are checking using <0
for failure
Comment 1 Tong Zhang 2020-08-27 00:20:42 UTC 
asmc_key_read() return 1 and 0 only, some callers are checking using <0
for failure
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-08-27 16:34:52 UTC 
A commit references this bug:

Author: markj
Date: Thu Aug 27 16:34:21 UTC 2020
New revision: 364871
URL: https://svnweb.freebsd.org/changeset/base/364871

Log:
  asmc(4): Handle errors from asmc_key_read() properly.

  asmc_key_read() returns only 0 and 1, some callers were checking
  incorrectly for failure.

  PR:		248939
  Submitted by:	Tong Zhang <ztong0001@gmail.com>
  MFC after:	1 week

Changes:
  head/sys/dev/asmc/asmc.c
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-09-03 13:56:52 UTC 
A commit references this bug:

Author: markj
Date: Thu Sep  3 13:56:48 UTC 2020
New revision: 365299
URL: https://svnweb.freebsd.org/changeset/base/365299

Log:
  MFC r364871:
  asmc(4): Handle errors from asmc_key_read() properly.

  PR:	248939

Changes:
_U  stable/12/
  stable/12/sys/dev/asmc/asmc.c