Bug 249013 - japanese/mh: Fix build failure on -current (with -fno-common)
Summary: japanese/mh: Fix build failure on -current (with -fno-common)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Li-Wen Hsu
URL:
Keywords: buildisok
Depends on:
Blocks: 248756
  Show dependency tree / graph
 
Reported: 2020-08-30 12:44 UTC by WATANABE Kazuhiro
Modified: 2021-03-13 20:33 UTC (History)
1 user (show)

See Also:
koobs: merge-quarterly?

Attachments
A patch for japanese/mh. (2.11 KB, patch)
2020-08-30 12:44 UTC, WATANABE Kazuhiro 		CQG00620: maintainer-approval+
Details | Diff
poudriere testport log on 13.0-CURRENT without the patch (671.81 KB, text/plain)
2020-08-30 12:48 UTC, WATANABE Kazuhiro 		no flags Details
poudriere testport log on 13.0-CURRENT with the patch (705.29 KB, text/plain)
2020-08-30 12:49 UTC, WATANABE Kazuhiro 		no flags Details
poudriere testport log on 13.0-ALPHA1 without the patch (285.45 KB, text/plain)
2021-01-18 09:09 UTC, WATANABE Kazuhiro 		no flags Details
poudriere testport log on 13.0-ALPHA1 with the patch (705.41 KB, text/plain)
2021-01-18 09:12 UTC, WATANABE Kazuhiro 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WATANABE Kazuhiro 2020-08-30 12:44:51 UTC 
Created attachment 217648 [details]
A patch for japanese/mh.

Current japanese/mh fails to build on 13.0-CURRENT due to the new default -fno-common compiler flag:

| ld: error: duplicate symbol: wantcomp
| >>> defined at fmtcompile.c
| >>>            fmtcompile.o:(wantcomp)
| >>> defined at formatsbr.c
| >>>            formatsbr.o:(.bss+0x60)
| cc: error: linker command failed with exit code 1 (use -v to see invocation)

This patch fixes the problem.
Comment 1 WATANABE Kazuhiro 2020-08-30 12:48:34 UTC 
Created attachment 217649 [details]
poudriere testport log on 13.0-CURRENT without the patch
Comment 2 WATANABE Kazuhiro 2020-08-30 12:49:15 UTC 
Created attachment 217650 [details]
poudriere testport log on 13.0-CURRENT with the patch
Comment 3 Automation User 2020-08-30 13:38:23 UTC 
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/183578169
Comment 4 WATANABE Kazuhiro 2021-01-18 09:06:59 UTC 
To committer:

This patch is still required for 13.0-CURRENT.  Would you apply the patch?
If you need more information, please ask me.
Comment 5 WATANABE Kazuhiro 2021-01-18 09:09:43 UTC 
Created attachment 221698 [details]
poudriere testport log on 13.0-ALPHA1 without the patch
Comment 6 WATANABE Kazuhiro 2021-01-18 09:12:02 UTC 
Created attachment 221699 [details]
poudriere testport log on 13.0-ALPHA1 with the patch
Comment 7 commit-hook freebsd_committer freebsd_triage 2021-03-13 20:32:54 UTC 
A commit references this bug:

Author: lwhsu
Date: Sat Mar 13 20:32:46 UTC 2021
New revision: 568281
URL: https://svnweb.freebsd.org/changeset/ports/568281

Log:
  japanese/mh: Fix build failure on 13 (with -fno-common)

  PR:		249013
  Submitted by:	WATANABE Kazuhiro <CQG00620@nifty.ne.jp> (maintainer)

Changes:
  head/japanese/mh/Makefile
  head/japanese/mh/files/patch-h_formatsbr.h
  head/japanese/mh/files/patch-sbr_fmtcompile.c