Bug 249014 - net/sngrep: Use release archive, backport LDFLAGS fix, fix OpenSSL support
Summary: net/sngrep: Use release archive, backport LDFLAGS fix, fix OpenSSL support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ryan Steinmetz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-30 13:07 UTC by Daniel Engberg
Modified: 2020-08-31 23:34 UTC (History)
2 users (show)

See Also:
tad: maintainer-feedback+


Attachments
Patch for sngrep (1.89 KB, patch)
2020-08-30 13:07 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2020-08-30 13:07:57 UTC
Created attachment 217651 [details]
Patch for sngrep

Use release archive instead of pulling source from GitHub repo as suggested by 5.4.3 in Porter's Handbook
Import upstream commit to fix LDFLAGS
Ref: https://github.com/irontec/sngrep/commit/1789d262c0ee90b1057181dc2abef681ba2233a6
Fix OpenSSL support, pkg-config doesn't pick up OpenSSL in base.

Compile tested on FreeBSD 13.0-CURRENT #0 r358620 (AMD64), r363135 (aarch64)
Poudriere OK 12.1-RELEASE (AMD64)
Comment 1 Talal Al Dik 2020-08-30 13:44:39 UTC
good, thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-08-31 23:34:26 UTC
A commit references this bug:

Author: zi
Date: Mon Aug 31 23:33:25 UTC 2020
New revision: 547217
URL: https://svnweb.freebsd.org/changeset/ports/547217

Log:
  - Use release archive
  - Backport LDFLAGS fix
  - Fix OpenSSL support
  - Bump PORTREVISION

  PR:		249014
  Submitted by:	daniel.engberg.lists@pyret.net

Changes:
  head/net/sngrep/Makefile
  head/net/sngrep/distinfo