Bug 249048 - x11-clocks/wmbinclock: fix recent "ld: error: duplicate symbol" breakage
Summary: x11-clocks/wmbinclock: fix recent "ld: error: duplicate symbol" breakage
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-01 08:28 UTC by Harold Gutch
Modified: 2020-09-02 10:14 UTC (History)
2 users (show)

See Also:
logix: maintainer-feedback+
fernape: merge-quarterly+

Attachments
svnlite diff (4.10 KB, patch)
2020-09-01 08:28 UTC, Harold Gutch 		no flags Details | Diff
additional improvements on top of submitter's patch (4.55 KB, patch)
2020-09-02 07:11 UTC, Fernando Apesteguía 		fernape: maintainer-approval? (logix)
 Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Harold Gutch 2020-09-01 08:28:35 UTC 
Created attachment 217687 [details]
svnlite diff

This fixes the recent build breakage that came with the clang update and the implicit "-fno-common".

While here, also address the other warnings when building the port.

Tested on -CURRENT as of Aug 27 and on 12.1-RELEASE, both with a current ports tree.

Added files:
  x11-clocks/wmbinclock/files/patch-wmBinClock.c
  x11-clocks/wmbinclock/files/patch-xutils.c
  x11-clocks/wmbinclock/files/patch-xutils.h
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2020-09-02 07:11:49 UTC 
Created attachment 217702 [details]
additional improvements on top of submitter's patch

Add a couple of missing xorg modules and remove a noop REINPLACE_CMD.
Comment 2 Harold Gutch 2020-09-02 09:00:08 UTC 
(In reply to Fernando Apesteguía from comment #1)

Looks good to me, thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-09-02 10:05:21 UTC 
A commit references this bug:

Author: fernape
Date: Wed Sep  2 10:05:07 UTC 2020
New revision: 547351
URL: https://svnweb.freebsd.org/changeset/ports/547351

Log:
  x11-clocks/wmbinclock: fix build in current

  Another case of -fno-common issue.

  While here, add a couple of missing xorg modules and remove a noop REINPLACE_CMD

  PR:	249048
  Submitted by:	logix@foobar.franken.de
  MFH:	2020Q3 (build fix, -fno-common)

Changes:
  head/x11-clocks/wmbinclock/Makefile
  head/x11-clocks/wmbinclock/files/
  head/x11-clocks/wmbinclock/files/patch-wmBinClock.c
  head/x11-clocks/wmbinclock/files/patch-xutils.c
  head/x11-clocks/wmbinclock/files/patch-xutils.h
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-09-02 10:13:23 UTC 
A commit references this bug:

Author: fernape
Date: Wed Sep  2 10:12:23 UTC 2020
New revision: 547352
URL: https://svnweb.freebsd.org/changeset/ports/547352

Log:
  MFH: r547351

  x11-clocks/wmbinclock: fix build in current

  Another case of -fno-common issue.

  While here, add a couple of missing xorg modules and remove a noop REINPLACE_CMD

  PR:	249048
  Submitted by:	logix@foobar.franken.de

  Approved by:	ports-secteam (blanket, build fix, -fno-common)

Changes:
_U  branches/2020Q3/
  branches/2020Q3/x11-clocks/wmbinclock/Makefile
  branches/2020Q3/x11-clocks/wmbinclock/files/
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2020-09-02 10:14:14 UTC 
Committed and MFH'ed.

Thanks!