Bug 249227 - benchmarks/netperf: Does not build on CURRENT after clang update to 11.0.0
Summary: benchmarks/netperf: Does not build on CURRENT after clang update to 11.0.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Serhii (Sergey) Kozlov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-10 09:17 UTC by Krzysztof Galazka
Modified: 2020-09-15 15:58 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (marius)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Galazka 2020-09-10 09:17:28 UTC 
There are duplicate variable definitions in nettest_bsd.c and nettest_omni.c files, which cause a build to fail with clang 11.0.0 and GCC 10.0 due to '-fno-common' option set by default. A fix awaits to be merged upstream: https://github.com/HewlettPackard/netperf/pull/48. Until then can it be applied in the port or can the '-fcommon' option be added to the compilation flags?

Thanks,
Krzysiek
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-09-15 15:56:12 UTC 
A commit references this bug:

Author: skozlov
Date: Tue Sep 15 15:55:43 UTC 2020
New revision: 548735
URL: https://svnweb.freebsd.org/changeset/ports/548735

Log:
  benchmarks/netperf: Fix build with clang 11 and gcc 10

  Tested using poudriere on 11.3, 12.1, 13.0

  PR:		249227
  Reported by:	Krzysztof Galazka
  Approved by:	build fix (blanket)
  Sponsored by:	Intel

Changes:
  head/benchmarks/netperf/Makefile
Comment 2 Serhii (Sergey) Kozlov freebsd_committer freebsd_triage 2020-09-15 15:58:29 UTC 
Small build fix, approval not needed. Thank you, Krzysiek, for the heads up.