Bug 249499 - devel/libconfuse: Use release archive
Summary: devel/libconfuse: Use release archive
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-21 08:56 UTC by Daniel Engberg
Modified: 2020-09-28 07:46 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (otis)

Attachments
Patch for libconfuse (1.29 KB, patch)
2020-09-21 08:56 UTC, Daniel Engberg 		no flags Details | Diff
devel/libconfuse: Download versioned archive (2.15 KB, patch)
2020-09-21 13:31 UTC, Juraj Lutter 		otis: maintainer-approval+
Details | Diff
devel/libconfuse: Download versioned archive (2.14 KB, patch)
2020-09-21 22:12 UTC, Juraj Lutter 		otis: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2020-09-21 08:56:20 UTC 
Created attachment 218136 [details]
Patch for libconfuse

Use release archive as recommended by upstream (https://github.com/libconfuse/libconfuse#introduction) and section 5.4.3 in Porter's Handbook.

Compile tested on FreeBSD 13.0-CURRENT #0 r364979 (AMD64) (make + make test)
Comment 1 Juraj Lutter freebsd_committer freebsd_triage 2020-09-21 13:31:11 UTC 
Created attachment 218146 [details]
devel/libconfuse: Download versioned archive

- Download versioned archive as suggested by upstream
- Add NLS support (and bump PORTREVISION)
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2020-09-21 22:01:46 UTC 
Thanks, NLS is always enabled by default so you don't need to set OPTIONS_DEFAULT

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html
5.13.1.3. Default Options
Comment 3 Juraj Lutter freebsd_committer freebsd_triage 2020-09-21 22:12:08 UTC 
Created attachment 218164 [details]
devel/libconfuse: Download versioned archive

Clean OPTIONS a bit
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-09-28 07:45:43 UTC 
A commit references this bug:

Author: arrowd
Date: Mon Sep 28 07:45:37 UTC 2020
New revision: 550404
URL: https://svnweb.freebsd.org/changeset/ports/550404

Log:
  devel/libconfuse: Use release archive as the distribution file instead of git tag

  PR:		249499
  Submitted by:	daniel.engberg.lists@pyret.net (original patch), Juraj Lutter <juraj@lutter.sk> (maintainer)

Changes:
  head/devel/libconfuse/Makefile
  head/devel/libconfuse/distinfo
  head/devel/libconfuse/pkg-plist
Comment 5 Gleb Popov freebsd_committer freebsd_triage 2020-09-28 07:46:27 UTC 
Committed, thanks.