Bug 250168 - devel/cscope: port cleanup
Summary: devel/cscope: port cleanup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rainer Hurling
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2020-10-06 21:22 UTC by Moritz Schmitt
Modified: 2020-10-07 16:04 UTC (History)
2 users (show)

See Also:

Attachments
Update of devel/cscope (1.65 KB, patch)
2020-10-06 21:22 UTC, Moritz Schmitt 		no flags Details | Diff
Poudriere test output (24.96 KB, text/plain)
2020-10-06 21:23 UTC, Moritz Schmitt 		no flags Details
Diff including patches (4.57 KB, text/plain)
2020-10-07 06:25 UTC, Moritz Schmitt 		moritz: maintainer-approval+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Moritz Schmitt 2020-10-06 21:22:38 UTC 
Created attachment 218575 [details]
Update of devel/cscope

This update is a general maintenance update.

- Makefile: Remove the first header line as any other header information except for '# $FreeBSD$' has been declared obsolete and is being phased out.

- Makefile: Change PORTVERSION to DISTVERSION as this is the preferred way.

- Makefile: Updated COMMENT as cscope is not a 'program browser' but more of a 'source code browser.'

- Makefile: Reorganized variable order.

- pkg-descr: Rewrote summary to make it more informative and relevant.

- pkg-descr: Included another WWW link that is more up-to-date than the project's homepage itself.

- Add patches to get rid of compiler warnings when building port.
Comment 1 Moritz Schmitt 2020-10-06 21:23:52 UTC 
Created attachment 218576 [details]
Poudriere test output
Comment 2 Rainer Hurling freebsd_committer freebsd_triage 2020-10-07 04:42:55 UTC 
(In reply to Moritz Schmitt from comment #0)

> Add patches to get rid of compiler warnings when building port.

Hi Moritz,

It seems, your patches did not find their way into into the PR?
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2020-10-07 05:47:28 UTC 
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]


Thanks!
Comment 4 Moritz Schmitt 2020-10-07 06:25:59 UTC 
Created attachment 218584 [details]
Diff including patches
Comment 5 Moritz Schmitt 2020-10-07 06:33:12 UTC 
(In reply to Rainer Hurling from comment #2)

Hi Rainer, you're right. I forgot to 'svn add' the patches. Sorry about that. Please find the new diff attached.
Comment 6 Moritz Schmitt 2020-10-07 06:34:58 UTC 
(In reply to Fernando Apesteguía from comment #3)

I set the flag. Maybe this is something that should be mentioned in the porter's handbook?
Comment 7 commit-hook freebsd_committer freebsd_triage 2020-10-07 16:00:09 UTC 
A commit references this bug:

Author: rhurlin
Date: Wed Oct  7 15:59:41 UTC 2020
New revision: 551653
URL: https://svnweb.freebsd.org/changeset/ports/551653

Log:
  devel/cscope: Port cleanup

  General maintenance update:

  - Remove Makefile line '#Created by' header
  - Change PORTVERSION to DISTVERSION
  - Correct COMMENT
  - Move GNU_CONFIGURE=yes up
  - Rewrite summary in pkg-descr
  - Include a second link
  - Add patches under files to suppress compiler warnings

  PR:		250168
  Submitted by:	Moritz Schmitt <moritz@schmi.tt> (maintainer)
  Approved by:	arrowd (mentor)
  Differential Revision:	https://reviews.freebsd.org/D26704

Changes:
  head/devel/cscope/Makefile
  head/devel/cscope/files/
  head/devel/cscope/files/patch-src_exec.c
  head/devel/cscope/files/patch-src_input.c
  head/devel/cscope/files/patch-src_invlib.c
  head/devel/cscope/pkg-descr
Comment 8 Rainer Hurling freebsd_committer freebsd_triage 2020-10-07 16:04:05 UTC 
Committed, thanks :)