Bug 250422 - Add quirk UQ_MSC_NO_SYNC_CACHE for rebranded EMTEC drive
Summary: Add quirk UQ_MSC_NO_SYNC_CACHE for rebranded EMTEC drive
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: usb (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-usb (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-17 20:43 UTC by vidwer+fbsdbugs
Modified: 2020-11-10 13:34 UTC (History)
1 user (show)

See Also:

Attachments
git diff to solve a USB drive quirk: 0x13fe vendor ID, 0x1e20 device ID: (1.18 KB, text/plain)
2020-10-17 20:43 UTC, vidwer+fbsdbugs 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description vidwer+fbsdbugs 2020-10-17 20:43:31 UTC 
Created attachment 218845 [details]
git diff to solve a USB drive quirk: 0x13fe vendor ID, 0x1e20 device ID:

$ sudo usbconfig -d 1.3 dump_device_desc
ugen1.3: <vendor 0x13fe USB DISK Pro> at usbus1, cfg=0 md=HOST spd=HIGH (480Mbps) pwr=ON (200mA)

  bLength = 0x0012 
  bDescriptorType = 0x0001 
  bcdUSB = 0x0200 
  bDeviceClass = 0x0000  <Probed by interface class>
  bDeviceSubClass = 0x0000 
  bDeviceProtocol = 0x0000 
  bMaxPacketSize0 = 0x0040 
  idVendor = 0x13fe 
  idProduct = 0x1e20 
  bcdDevice = 0x0110 
  iManufacturer = 0x0001  <        >
  iProduct = 0x0002  <USB DISK Pro    >
  iSerialNumber = 0x0003  </*snip*/>
  bNumConfigurations = 0x0001 

From dmesg, with a prepatched kernel and booting in verbose mode:

ugen1.3: <vendor 0x13fe USB DISK Pro> at usbus1
umass0 on uhub3
umass0: <vendor 0x13fe USB DISK Pro, class 0/0, rev 2.00/1.10, addr 2> on usbus1
umass0:  SCSI over Bulk-Only; quirks = 0x4000
umass0:2:0: Attached to scbus2
(probe0:umass-sim0:0:0:0): Down reving Protocol Version from 2 to 0?
pass2 at umass-sim0 bus 0 scbus2 target 0 lun 0
pass2: < USB DISK Pro PMAP> Removable Direct Access SCSI device
pass2: Serial Number /*snip*/
pass2: 40.000MB/s transfers
GEOM: new disk da0
da0 at umass-sim0 bus 0 scbus2 target 0 lun 0
da0: < USB DISK Pro PMAP> Removable Direct Access SCSI device
da0: Serial Number /*snip*/
da0: 40.000MB/s transfers
da0: 3934MB (8056832 512 byte sectors)
da0: quirks=0x3<NO_SYNC_CACHE,NO_6_BYTE>
da0: Delete methods: <NONE(*),ZERO>
(probe0:umass-sim0:0:0:1): Down reving Protocol Version from 2 to 0?
pass3 at umass-sim0 bus 0 scbus2 target 0 lun 1
pass3: < USB DISK Pro PMAP> Removable Direct Access SCSI device
pass3: Serial Number /*snip*/
pass3: 40.000MB/s transfers
(da0:umass-sim0:0:0:0): PREVENT ALLOW MEDIUM REMOVAL not supported.
da1 at umass-sim0 bus 0 scbus2 target 0 lun 1
da1: < USB DISK Pro PMAP> Removable Direct Access SCSI device
da1: Serial Number /*snip*/
da1: 40.000MB/s transfers
da1: 1MB (2880 512 byte sectors)
da1: quirks=0x3<NO_SYNC_CACHE,NO_6_BYTE>
da1: Delete methods: <NONE(*),ZERO>
GEOM: new disk da1
(da1:umass-sim0:0:0:1): PREVENT ALLOW MEDIUM REMOVAL not supported.
Comment 1 Hans Petter Selasky freebsd_committer freebsd_triage 2020-10-18 08:58:26 UTC 
Thank you!
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-10-18 08:58:31 UTC 
A commit references this bug:

Author: hselasky
Date: Sun Oct 18 08:58:15 UTC 2020
New revision: 366806
URL: https://svnweb.freebsd.org/changeset/base/366806

Log:
  Add new USB quirk.

  PR:			250422
  Submitted by:		vidwer+fbsdbugs@gmail.com
  MFC after:		1 week
  Sponsored by:		Mellanox Technologies // NVIDIA Networking

Changes:
  head/sys/dev/usb/quirk/usb_quirk.c
  head/sys/dev/usb/usbdevs
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-11-10 13:33:27 UTC 
A commit references this bug:

Author: hselasky
Date: Tue Nov 10 13:32:50 UTC 2020
New revision: 367564
URL: https://svnweb.freebsd.org/changeset/base/367564

Log:
  MFC r366806:
  Add new USB quirk.

  PR:			250422
  Submitted by:		vidwer+fbsdbugs@gmail.com
  Sponsored by:		Mellanox Technologies // NVIDIA Networking

Changes:
_U  stable/12/
  stable/12/sys/dev/usb/quirk/usb_quirk.c
  stable/12/sys/dev/usb/usbdevs
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-11-10 13:34:28 UTC 
A commit references this bug:

Author: hselasky
Date: Tue Nov 10 13:33:39 UTC 2020
New revision: 367565
URL: https://svnweb.freebsd.org/changeset/base/367565

Log:
  MFC r366806:
  Add new USB quirk.

  PR:			250422
  Submitted by:		vidwer+fbsdbugs@gmail.com
  Sponsored by:		Mellanox Technologies // NVIDIA Networking

Changes:
_U  stable/11/
  stable/11/sys/dev/usb/quirk/usb_quirk.c
  stable/11/sys/dev/usb/usbdevs