Created attachment 219183 [details] svn diff Biboumi is gateway that connects to IRC from a XMPP server, allowing to join IRC discussions from an XMPP client. portlint and poudriere testport OK
Created attachment 225895 [details] v2 Patch on top of yours to fix couple of issues: - remove $FreeBSD$ header - fetch the dependency through ports system which it's trying to fetch with git, as network won't be available in sandboxed/jailed builder environments - fix the dependency on sphinx
Created attachment 225896 [details] patch for the UIDs, and GIDs file Updated patch for UIDs, and GIDs file now that previous UID/GID are not available anymore.
Use tar.xz archive ( https://biboumi.louiz.org/ ) CMAKE_ARGS+= should be CMAKE_ARGS= and be placed below GITHUB variables Why do we pull in both sqlite and postgre by default? Ordering is a bit odd, XXX_DESC should preferably be grouped and be placed below OPTIONS_DEFAULT No need to use DESC for sqlite and postgre?
Thanks for the patchs and reviews. Postgres and sqlite are both enabled by default to ease the use of one of the other to store biboumi's data. But if it's not common in FreeBSD ports maybe we can let only sqlite enabled by default ? About the databases options DESC, I thought it would be better to be more explicit about what the databases are used for. I' put a new diff (git) in attachment with: - Ashish's fixes (UIDs/GIDs, $FreeBSD$ header removal, dependency fetch, sphinx) - addition of tar:xz USE - reordering of GITHUB and DESC vars - fix CMAKE_ARGS usage
Created attachment 226160 [details] updated diff (git)
(In reply to samir from comment #5) Thanks for the update. A small correction, since pkg-message contains variables to be substituted (%%PREFIX%%), could you please move it to files/pkg-message.in, and then designate it to be substituted: @@ -63,6 +60,7 @@ USE_RC_SUBR= biboumi SUB_LIST= USER=${USERS} GROUP=${GROUPS} PLIST_SUB= ${SUB_LIST} +SUB_FILES= pkg-message post-patch: ${REINPLACE_CMD} -e 's,GIT_REPOSITORY.*Catch.git",SOURCE_DIR "${WRKSRC}/external/src/catch",' ${WRKSRC}/CMakeLists.txt Thanks!
Created attachment 226535 [details] Updated git diff with pkg-message.in In attachment a new diff with usage of pkg-message.in Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5f49d1f3a82c393bb865e7ca43c06aa591e78b84 commit 5f49d1f3a82c393bb865e7ca43c06aa591e78b84 Author: samir <samir@noir.im> AuthorDate: 2021-07-20 22:06:41 +0000 Commit: Ashish SHUKLA <ashish@FreeBSD.org> CommitDate: 2021-07-20 22:11:30 +0000 net-im/biboumi: new port: XMPP gateway to IRC Biboumi is a Free, Libre and Open Source XMPP gateway that connects to IRC servers and translates between the two protocols. Its goal is to let XMPP users take part in IRC discussions, using their favourite XMPP client. WWW: https://biboumi.louiz.org/ PR: 250705 GIDs | 2 +- UIDs | 2 +- net-im/biboumi/Makefile (new) | 91 +++++++++++++++++++++++++++ net-im/biboumi/distinfo (new) | 5 ++ net-im/biboumi/files/biboumi.in (new) | 37 +++++++++++ net-im/biboumi/files/patch-doc_Makefile (new) | 11 ++++ net-im/biboumi/files/pkg-message.in (new) | 5 ++ net-im/biboumi/pkg-descr (new) | 5 ++ net-im/biboumi/pkg-plist (new) | 10 +++ 9 files changed, 166 insertions(+), 2 deletions(-)
Committed, thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=4642ccc60e9e00c2c50e57d419c9d402eda682e8 commit 4642ccc60e9e00c2c50e57d419c9d402eda682e8 Author: Ashish SHUKLA <ashish@FreeBSD.org> AuthorDate: 2021-07-21 11:06:29 +0000 Commit: Ashish SHUKLA <ashish@FreeBSD.org> CommitDate: 2021-07-21 11:08:16 +0000 net-im/biboumi: Link to the build PR: 250705 Reported by: antoine net-im/Makefile | 1 + 1 file changed, 1 insertion(+)