Bug 250757 - graphics/nomacs: update to 3.16
Summary: graphics/nomacs: update to 3.16
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://nomacs.org/nomacs-3-16/
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2020-10-31 16:34 UTC by Vidar Karlsen
Modified: 2020-11-04 07:27 UTC (History)
1 user (show)

See Also:

Attachments
svn diff (note the deletion of a file) (7.87 KB, patch)
2020-10-31 16:34 UTC, Vidar Karlsen 		vidar: maintainer-approval+
Details | Diff
Fixed diff (8.83 KB, patch)
2020-11-03 19:23 UTC, Vidar Karlsen 		vidar: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vidar Karlsen 2020-10-31 16:34:54 UTC 
Created attachment 219253 [details]
svn diff (note the deletion of a file)

QA:
Builds and runs on 12.2.
portlint -C: looks fine.


Changes:
nomacs 3.16 is mainly improved behind the scenes. A few new features were added though:

- AVIF support
- CR3, PCX support
- image editing: blurring added
- plugins: adds composite plugin
- windows: new multi-user installer
- adds default system theme
- flatpak: adds plugins
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2020-11-03 18:52:26 UTC 
Fails to patch:

===>  Applying FreeBSD patches for nomacs-3.16 from /data/fernape_data/FreeBSD-repos/ports/head/graphics/nomacs/files
Ignoring previously applied (or reversed) patch.
1 out of 1 hunks ignored--saving rejects to ImageLounge/plugins/PageExtractionPlugin/src/DkPageSegmentation.cpp.rej
===>  FAILED Applying FreeBSD patch-ImageLounge_plugins_PageExtractionPlugin_src_DkPageSegmentation.cpp
===> FAILED to apply cleanly FreeBSD patch(es)  patch-ImageLounge_plugins_PageExtractionPlugin_src_DkPageSegmentation.cpp
*** Error code 1

Stop.
make[1]: stopped in /data/fernape_data/FreeBSD-repos/ports/head/graphics/nomacs
*** Error code 1

Stop.
make: stopped in /data/fernape_data/FreeBSD-repos/ports/head/graphics/nomacs

It seems #include <QPainterPath> is already in DkPageSegmentation.cpp...
Comment 2 Vidar Karlsen 2020-11-03 19:23:13 UTC 
Created attachment 219328 [details]
Fixed diff

Ooops, I forgot to 'svn rm' the second patch in files/.
This should work now.
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-11-04 07:26:57 UTC 
A commit references this bug:

Author: fernape
Date: Wed Nov  4 07:26:29 UTC 2020
New revision: 554056
URL: https://svnweb.freebsd.org/changeset/ports/554056

Log:
  graphics/nomacs: update to 3.16

  From ChangeLog: https://nomacs.org/nomacs-3-16/

   * AVIF support
   * CR3, PCX support
   * image editing: blurring added
   * plugins: adds composite plugin
   * windows: new multi-user installer
   * adds default system theme
   * flatpak: adds plugins

  PR:	250757
  Submitted by:	vidar@karlsen.tech (maintainer)

Changes:
  head/graphics/nomacs/Makefile
  head/graphics/nomacs/distinfo
  head/graphics/nomacs/files/patch-ImageLounge_3rdparty_drif_drif__image.h
  head/graphics/nomacs/files/patch-ImageLounge_plugins_PageExtractionPlugin_src_DkPageSegmentation.cpp
  head/graphics/nomacs/pkg-plist
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2020-11-04 07:27:18 UTC 
Committed,

Thanks!