Bug 251961 - /etc/periodic/daily/221.backup-gpart: daily_backup_gpart_exclude doesn't work properly
Summary: /etc/periodic/daily/221.backup-gpart: daily_backup_gpart_exclude doesn't work...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: conf (show other bugs)
Version: 12.2-STABLE
Hardware: Any Any
: --- Affects Only Me
Assignee: Ed Maste
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-19 13:31 UTC by Kan Sasaki
Modified: 2021-01-04 18:50 UTC (History)
1 user (show)

See Also:

Attachments
patch for 221.backup-gpart (498 bytes, patch)
2020-12-19 13:31 UTC, Kan Sasaki 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kan Sasaki 2020-12-19 13:31:42 UTC 
Created attachment 220718 [details]
patch for 221.backup-gpart

Since gpart_devs is not quoted, if daily_backup_gpart_exclude matches something, gpart_devs will be empty.
Comment 1 Ed Maste freebsd_committer freebsd_triage 2020-12-19 19:40:56 UTC 
I'll pick this up
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-12-27 00:28:24 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=93900fc697992f893e2e69dce0c2f67b1f66a774

commit 93900fc697992f893e2e69dce0c2f67b1f66a774
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2020-12-27 00:24:18 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2020-12-27 00:27:12 +0000

    Fix daily_backup_gpart_exclude in periodic daily 221.backup-gpart

    Since gpart_devs was not quoted (losing embedded newlines), if
    daily_backup_gpart_exclude matched something, gpart_devs was empty.

    PR:             251961
    Submitted by:   Kan Sasaki
    MFC after:      1 week

 usr.sbin/periodic/etc/daily/221.backup-gpart | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-01-04 18:48:35 UTC 
A commit in branch stable/12 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=25e00a2894ea4ea2cbe64f25d9f3d99b60d1ea32

commit 25e00a2894ea4ea2cbe64f25d9f3d99b60d1ea32
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2020-12-27 00:24:18 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2021-01-04 18:47:46 +0000

    Fix daily_backup_gpart_exclude in periodic daily 221.backup-gpart

    Since gpart_devs was not quoted (losing embedded newlines), if
    daily_backup_gpart_exclude matched something, gpart_devs was empty.

    PR:             251961
    Submitted by:   Kan Sasaki

    (cherry picked from commit 93900fc697992f893e2e69dce0c2f67b1f66a774)

 usr.sbin/periodic/etc/daily/221.backup-gpart | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Ed Maste freebsd_committer freebsd_triage 2021-01-04 18:50:47 UTC 
Fixed in main and stable/12 now, thank you for the report and fix!