Bug 251985 - audio/lame: Add libsndfile support
Summary: audio/lame: Add libsndfile support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexander Leidinger
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-12-20 13:04 UTC by Bernard Spil
Modified: 2022-03-27 12:06 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (netchild)

Attachments
svn diff for audio/lame (492 bytes, patch)
2020-12-20 13:04 UTC, Bernard Spil 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bernard Spil freebsd_committer freebsd_triage 2020-12-20 13:04:04 UTC 
Created attachment 220748 [details]
svn diff for audio/lame
Comment 1 Automation User 2021-01-04 00:12:46 UTC 
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/236843157
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-03-20 06:38:42 UTC 
Any process on this one? Another solution if you need support for "odd" formats is to use ffmpeg which also includes lame support ootb.
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2022-03-20 06:39:03 UTC 
Err.. progress not process, early in the morning ;)
Comment 4 Alexander Leidinger freebsd_committer freebsd_triage 2022-03-20 21:31:36 UTC 
Hi,

there was an issue reported "recently" (to the LAME project) when sndfile is in use. What about having the option off by default instead? There are now a lot of years where we build the lame port without sndfile support, and there are not much complains, so I think there is not much demand for the additional formats to support.

Bye,
Alexander.
Comment 5 Bernard Spil freebsd_committer freebsd_triage 2022-03-26 12:19:12 UTC 
Default off is fine for me.
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-03-27 12:05:51 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6f07c5e3e9a5dc55d32821744d58264e815f6c10

commit 6f07c5e3e9a5dc55d32821744d58264e815f6c10
Author:     Bernard Spil <brnrd@FreeBSD.org>
AuthorDate: 2022-03-27 12:03:47 +0000
Commit:     Alexander Leidinger <netchild@FreeBSD.org>
CommitDate: 2022-03-27 12:03:47 +0000

    audio/lame: add option to depend on libsndfile

    Defaults to off.
    PR:             251985

 audio/lame/Makefile | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)