Bug 252043 - net/syncthing - anonymize longVersion reported by syncthing
Summary: net/syncthing - anonymize longVersion reported by syncthing
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-22 05:51 UTC by Peter Jeremy
Modified: 2020-12-27 19:58 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (swills)

Attachments
Anonymize syncthing builder. (308 bytes, patch)
2020-12-22 05:51 UTC, Peter Jeremy 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Jeremy freebsd_committer freebsd_triage 2020-12-22 05:51:58 UTC 
Created attachment 220808 [details]
Anonymize syncthing builder.

syncthing reports a long version string that, by default, includes details of the user that built the package and the hostname it was built on.  (This can be seen by previewing the "Anonymous Usage Reporting" under General Settings).  Since (eg) "peter@server.rulingia.com" is not very anonymous, it would nice if the port changed this to a suitably general identifier.  Luckily, the code allows the default value to be overridden via environment variables (see buildUser() and buildHost() in syncthing/build.go).

Looking through the "Version 3" usage reporting data, there doesn't appear to be any other data of concern reported.

Looking at the "Builder" strings reported via https://data.syncthing.net/, changing the defaults seems fairly common.

The attached patch changes the identification string to "ports@freebsd".
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-12-27 19:56:30 UTC 
A commit references this bug:

Author: swills
Date: Sun Dec 27 19:56:02 UTC 2020
New revision: 559415
URL: https://svnweb.freebsd.org/changeset/ports/559415

Log:
  net/syncthing - anonymize longVersion reported

  PR:		252043
  Submitted by:	peterj

Changes:
  head/net/syncthing/Makefile
Comment 2 Steve Wills freebsd_committer freebsd_triage 2020-12-27 19:58:58 UTC 
Committed, thanks!