Created attachment 220890 [details] Yadifa 2.4.1 EurID released a new version of Yadifa. This patch updates accordingly. Tested in poudriere (but only against 12.1 AMD). Further this includes all the intended improvements of PR244362, but then more code-efficient: some features need specifically "disable" others an implicit "enable".
Created attachment 220912 [details] yadifa 2.4.1 patch with style cleaned up yadifa 2.4.1 patch with style cleaned up using portlint, portclippy, portfmt. No functional changes. Would you mind to review and approve, so we can proceed?
Comment on attachment 220912 [details] yadifa 2.4.1 patch with style cleaned up Took me a while to verify (apply both the patches), but (together) indeed it's equal and nicer.
Looks like the approval confirm doesn't work. But approved.
Created attachment 221033 [details] yadifa 2.4.1 patch with style cleaned up
Verified by eye / tested in Poudriere. Contains everything, works all fine - approved.
Comment on attachment 220890 [details] Yadifa 2.4.1 improved by patch 221033
A commit references this bug: Author: otis Date: Thu Dec 31 18:04:12 UTC 2020 New revision: 559762 URL: https://svnweb.freebsd.org/changeset/ports/559762 Log: dns/yadifa: update to 2.4.1 * YADIFA 2.4.1-public: - Fixes an issue in dnscore where a DNS TCP query would not return the real DNS error code. - Fixes an issue that could happen when a network model isn't supported. - Fixes the propagation of sendmmsg/recvmmsg function availability detection. - Fixes an issue where yadifad would issue a warning when a key with algorithm > 7 is used with an NSEC zone. - Fixes an issue that will occur on a chrooted environment where a managed-path would be used incorrectly. - Fixes CNAME answers not following the aliases chain. - Fixes CNAME recursion not returning the same answer as named in NXDOMAIN cases (reported by https://github.com/SivaKesava1, see https://github.com/yadifa/yadifa/issues/11) - Adds patch for musl support - Adds stack size fix for musl support (the default size is way too small) - Now imports a custom version of stdatomic.h for systems where it is missing, located in dnscore/thirdpary/stdatomic.h. Made for CentOS 7 and any other release where that file is missing. The import is only active if strictly needed and will only be visible during the build. At the moment, it is not being installed with the other headers. * YAKEYROLLD 2.4.1: - Fixes the handling of incomplete TCP queries. - Fixes a possible race-condition when initialising the keyroll context error codes. - The keyroll now has another automatic recovery layer where it completely restarts the handling of a domain, generating a one-step update to put the zone in the expected state. Full changelog at https://github.com/yadifa/yadifa/blob/master/ChangeLog And while here, reformat Makefile according to portfmt and portclippy PR: 252107 Submitted by: Leo Vandewoestijne <freebsd@dns.company> (maintainer) Reviewed by: osa (mentor) Approved by: osa (mentor) Differential Revision: https://reviews.freebsd.org/D27808 Changes: head/dns/yadifa/Makefile head/dns/yadifa/distinfo head/dns/yadifa/pkg-plist
Committed, thanks.