Bug 252802 - net/openntpd: switch to libretls on FreeBSD 12+
Summary: net/openntpd: switch to libretls on FreeBSD 12+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Christian Weisgerber
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2021-01-18 12:29 UTC by Jan Beich
Modified: 2021-01-18 20:04 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (naddy)

Attachments
v1 (2.20 KB, patch)
2021-01-18 12:29 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2021-01-18 12:29:43 UTC 
Created attachment 221704 [details]
v1

Expose libtls dependency as TLS option. When using LibreSSL use its own libtls but when using OpenSSL use libtls from libretls.

--- libressl
+++ openssl
@@ -1,7 +1,7 @@
 =>> Checking shared library dependencies
  0x0000000000000001 NEEDED               Shared library: [libc.so.7]
- 0x0000000000000001 NEEDED               Shared library: [libcrypto.so.46]
+ 0x0000000000000001 NEEDED               Shared library: [libcrypto.so.111]
  0x0000000000000001 NEEDED               Shared library: [libm.so.5]
- 0x0000000000000001 NEEDED               Shared library: [libssl.so.48]
+ 0x0000000000000001 NEEDED               Shared library: [libssl.so.111]
  0x0000000000000001 NEEDED               Shared library: [libthr.so.3]
  0x0000000000000001 NEEDED               Shared library: [libtls.so.20]

On FreeBSD < 12 we have to continue using ugly workaround because security/libretls fails to build.
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-01-18 20:03:12 UTC 
A commit references this bug:

Author: naddy
Date: Mon Jan 18 20:02:16 UTC 2021
New revision: 561963
URL: https://svnweb.freebsd.org/changeset/ports/561963

Log:
  net/openntpd: switch to libretls on FreeBSD 12+

  When using LibreSSL use its own libtls but when using OpenSSL use
  libtls from libretls.

  Reworked from
  PR:		252802
  Submitted by:	jbeich

Changes:
  head/net/openntpd/Makefile
Comment 2 Christian Weisgerber freebsd_committer freebsd_triage 2021-01-18 20:04:01 UTC 
Thanks. I do not want to make constraint support optional, so I committed a simplified version without the OPTION.