Bug 252841 - WITHOUT_CRYPT build option regression
Summary: WITHOUT_CRYPT build option regression
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Mitchell Horne
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-20 02:46 UTC by Michael Dexter
Modified: 2021-02-04 14:03 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Dexter freebsd_triage 2021-01-20 02:46:58 UTC 
The WITHOUT_CRYPT build option has regressed since at least 13.0-CURRENT 20200514-r361019

Build error output:

--- lib/libthr__L ---
--- lib/libsbuf__L ---
--- cddl/lib/libumem__L ---
--- cddl/lib/libnvpair__L ---
--- cddl/lib/libavl__L ---
--- cddl/lib/libicp__L ---
--- cddl/lib/libicp_rescue__L ---
--- cddl/lib/libspl__L ---
make[3]: make[3]: don't know how to make secure/lib/libcrypto__L. Stop

More available upon request.

Adrian Chadd may have insights into this.
Comment 1 Michael Dexter freebsd_triage 2021-01-23 23:08:44 UTC 
Confirmed on FreeBSD 13.0-ALPHA2 build on 13.0-ALPHA2.

Full built output is linked from: https://callfortesting.org/results/bos-FreeBSD-13A1/
Comment 2 Michael Dexter freebsd_triage 2021-01-30 03:03:15 UTC 
Confirmed on FreeBSD 13.0-ALPHA3 built on 13.0-ALPHA3.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-02-01 14:41:50 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=e5cc1c47484160969e0a7c13cdbc71081d7dd60e

commit e5cc1c47484160969e0a7c13cdbc71081d7dd60e
Author:     Mitchell Horne <mhorne@FreeBSD.org>
AuthorDate: 2021-01-30 19:04:08 +0000
Commit:     Mitchell Horne <mhorne@FreeBSD.org>
CommitDate: 2021-02-01 14:31:17 +0000

    src.opts.mk: set MK_ZFS conditional on MK_OPENSSL

    libzfs has a dependency on libcrypto. This causes a buildworld link
    failure when WITHOUT_OPENSSL/WITHOUT_CRYPT is set.

    This dependency was added implicitly by the switch to OpenZFS, and
    explicitly in 40d0fd287510 and cd568e2b1b67.

    PR:             252841
    Reviewed by:    kevans, freqlabs
    MFC after:      3 days
    Differential Revision:  https://reviews.freebsd.org/D28431

 share/mk/src.opts.mk | 1 +
 1 file changed, 1 insertion(+)
Comment 4 Michael Dexter freebsd_triage 2021-02-02 07:32:55 UTC 
Initial builds are fine! Thanks!
Closing
Comment 5 Mitchell Horne freebsd_committer freebsd_triage 2021-02-02 14:00:27 UTC 
(In reply to Michael Dexter from comment #4)

No problem. I will MFC to stable/13 in the next couple of days.
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-02-04 14:03:37 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=63a3f59066765c251de8cb80bf841b916b4f4061

commit 63a3f59066765c251de8cb80bf841b916b4f4061
Author:     Mitchell Horne <mhorne@FreeBSD.org>
AuthorDate: 2021-01-30 19:04:08 +0000
Commit:     Mitchell Horne <mhorne@FreeBSD.org>
CommitDate: 2021-02-04 13:57:31 +0000

    src.opts.mk: set MK_ZFS conditional on MK_OPENSSL

    PR:             252841
    Reviewed by:    kevans, freqlabs

    (cherry picked from commit e5cc1c47484160969e0a7c13cdbc71081d7dd60e)

 share/mk/src.opts.mk | 1 +
 1 file changed, 1 insertion(+)